Add a -xpcshell option to SeaMonkey

ASSIGNED
Assigned to

Status

--
enhancement
ASSIGNED
3 years ago
11 months ago

People

(Reporter: philip.chee, Assigned: rn10950, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][gfb][lang=c++])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
(In reply to Mike Hommey [:glandium] from bug 1238769 comment #0)
> Now that xpcshell is just a (literal) shell around XRE_XPCShellMain, we can
> actually just make Firefox itself work as the xpcshell.
(In reply to Philip Chee from comment #0)
> (In reply to Mike Hommey [:glandium] from bug 1238769 comment #0)
> > Now that xpcshell is just a (literal) shell around XRE_XPCShellMain, we can
> > actually just make Firefox itself work as the xpcshell.

IIUC this bug consists of porting to SeaMonkey Firefox bug 1238769 (assigned to glandium and which, as of this writing, has been pushed to inbound, backed out, and then given an updated patch)? The patch consists of an added else-block in one if statement and a few sporadic lines elsewhere. I'm interested to try, but not before that other bug gets FIXED, and only if no one else wants to.
(Assignee)

Comment 2

3 years ago
I can take this.
Assignee: nobody → rn10950
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
Created attachment 8719380 [details] [diff] [review]
bug1245914_xpcshell.diff

When I run the executable with -xpcshell, nothing happens, seamonkey.exe runs and closes with no error or any output in the parent CMD window, however, the latest Firefox Nightly (build 20160214030236) behaves the same way, so I am submitting this patch as-is. (bug 1238769's patch was merged to m-c on 2016-02-10) Otherwise, the suite runs fine, and there are no build errors.
Attachment #8719380 - Flags: review?(philip.chee)
Comment on attachment 8719380 [details] [diff] [review]
bug1245914_xpcshell.diff

Why the additional indent at new line 128?   {nullptr, nullptr}
(Assignee)

Comment 5

3 years ago
(In reply to Tony Mechelynck [:tonymec] from comment #4)
> Comment on attachment 8719380 [details] [diff] [review]
> bug1245914_xpcshell.diff
> 
> Why the additional indent at new line 128?   {nullptr, nullptr}

For some reason, Notepad++ replaced the 4 spaces with a tab. I went back in and changed it.
(Assignee)

Comment 6

3 years ago
Created attachment 8719564 [details] [diff] [review]
patch with wierd indent fixed
Attachment #8719380 - Attachment is obsolete: true
Attachment #8719380 - Flags: review?(philip.chee)
Attachment #8719564 - Flags: review?(philip.chee)
(In reply to rn10950 from comment #3)
> Created attachment 8719380 [details] [diff] [review]
> bug1245914_xpcshell.diff
> 
> When I run the executable with -xpcshell, nothing happens, seamonkey.exe
> runs and closes with no error or any output in the parent CMD window,
> however, the latest Firefox Nightly (build 20160214030236) behaves the same
> way, so I am submitting this patch as-is. (bug 1238769's patch was merged to
> m-c on 2016-02-10) Otherwise, the suite runs fine, and there are no build
> errors.

The added lines indicate that any command-line arguments after -xpcshell, and any environment variables, get passed to XRE_XPCShellMain() at new line 172. What these arguments and variables might be, the Firefox bug doesn't say, but I suppose they are described somewhere, maybe in the MDN or mozwiki documentation (if there is any) about xpcshell.
(Reporter)

Comment 8

3 years ago
Comment on attachment 8719564 [details] [diff] [review]
patch with wierd indent fixed

Neil is a better reviewer for C++ code.
Attachment #8719564 - Flags: review?(philip.chee) → review?(neil)

Comment 9

11 months ago
Hello, can I please work on this bug?
Comment on attachment 8719564 [details] [diff] [review]
patch with wierd indent fixed

Neil is no longer active here. rn10950 also sees to be gone from bugzilla. p.sonalipatro I think this bug is no no longer valid. nsSuiteGlue.app was aligned with the one in browser in several recent bugs. Could you check.
Attachment #8719564 - Flags: review?(neil)
You need to log in before you can comment on or make changes to this bug.