1245930 - Disable zoomed view

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[:Margaret Leibovic]

As I mentioned in bug 1229349 comment 5, we should disable the zoomed view to avoid blocking APZ. Let's land this for 45.

NI to barbara to confirm product direction.

Comment 1

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1245930 - Disable zoomed view on non-Nightly builds. r=mcomella

Review commit: https://reviewboard.mozilla.org/r/34797/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34797/

Comment 2

[:Margaret Leibovic]

Let's disable this on non-Nightly builds, and we can figure out what to do with the feature in bug 1229349.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8718923 [details]
MozReview Request: Bug 1245930 - Disable zoomed view on non-Nightly builds. r=mcomella

https://reviewboard.mozilla.org/r/34797/#review31461

While I think this should work, we'll also want to prevent the zoomed view from inflating on these other builds in `BrowserApp.handleMessage`, like https://bugzilla.mozilla.org/attachment.cgi?id=8685602&action=diff

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

And to be clear, it is my understanding that we're disabling this until APZ lands and this is fixed on APZ (bug 1229349) so we don't end up having to take the zoomed view away from users. At that point, we'll decide how much effort it is to maintain the zoomed view on Nightly and if it's negligible, we'll ship it again.

Comment 5

[:Margaret Leibovic]

(In reply to Michael Comella (:mcomella) from comment #3)
> Comment on attachment 8718923 [details]
> MozReview Request: Bug 1245930 - Disable zoomed view on non-Nightly builds.
> r=mcomella
> 
> https://reviewboard.mozilla.org/r/34797/#review31461
> 
> While I think this should work, we'll also want to prevent the zoomed view
> from inflating on these other builds in `BrowserApp.handleMessage`, like
> https://bugzilla.mozilla.org/attachment.cgi?id=8685602&action=diff

Sigh, this should go behind the pref for the feature if that's the case! This means that we're already inflating this view on release builds where this feature is disabled.

Comment 6

[:Margaret Leibovic]

(In reply to :Margaret Leibovic from comment #5)
> (In reply to Michael Comella (:mcomella) from comment #3)
> > Comment on attachment 8718923 [details]
> > MozReview Request: Bug 1245930 - Disable zoomed view on non-Nightly builds.
> > r=mcomella
> > 
> > https://reviewboard.mozilla.org/r/34797/#review31461
> > 
> > While I think this should work, we'll also want to prevent the zoomed view
> > from inflating on these other builds in `BrowserApp.handleMessage`, like
> > https://bugzilla.mozilla.org/attachment.cgi?id=8685602&action=diff
> 
> Sigh, this should go behind the pref for the feature if that's the case!
> This means that we're already inflating this view on release builds where
> this feature is disabled.

I'm wrong, this isn't the case in release:
http://hg.mozilla.org/releases/mozilla-release/file/tip/mobile/android/base/BrowserApp.java#l753

But the case still stands that this is a bad feature pref if it doesn't disable all the parts of the feature.

Comment 7

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/f7b64f45c4fb8a06514b878dbec85f35654766e0
Bug 1245930 - Disable zoomed view on non-Nightly builds. r=mcomella

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f7b64f45c4fb

Comment 9

[:Margaret Leibovic]

Comment on attachment 8718923 [details]
MozReview Request: Bug 1245930 - Disable zoomed view on non-Nightly builds. r=mcomella

Approval Request Comment
[Feature/regressing bug #]: This is a new feature that we were planning to ship in 45, but it was broken in Nightly by APZ changes, and then by bug 1247095. This is a lower priority than other platform changes we're working on right now, and we don't want to block that work on fixing this in 47, so we'd like to just not ship this feature as a precaution.

[User impact if declined]: Potentially broken new feature in the future.

[Describe test coverage new/current, TreeHerder]: None.

[Risks and why]: Low-risk, disabling a feature.

[String/UUID change made/needed]: None.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8718923 [details]
MozReview Request: Bug 1245930 - Disable zoomed view on non-Nightly builds. r=mcomella

Sure, let's take it.
Should be in 45 beta 8

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9ecb3d772d8f

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0d538bb39c99

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

There was some merge conflict introduced when I uplifted this to beta. Should be fixed in https://hg.mozilla.org/releases/mozilla-beta/rev/49d5c178d339

Checking what landed to aurora to see if it needs the fix too.

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Aurora looks fine, for the record.

Comment 15

[Teodora Vermesan (:TeoVermesan)]

"ui.zoomedview.enabled=false"

Verified as fixed using:
Device: Nexus 6 (Android 6.0) and Nexus 9 (Android 6.0.1)
Build: Firefox for Android 45.0b9 build 2 and Firefox for Android 46.0a2 (2016-02-24)