Closed Bug 1245937 Opened 4 years ago Closed 4 years ago

INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/chat/browser_chatwindow.js | This test exceeded the timeout threshold

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(firefox45 wontfix, firefox46 fixed, firefox47 fixed, firefox48 fixed, firefox-esr45 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox45 --- wontfix
firefox46 --- fixed
firefox47 --- fixed
firefox48 --- fixed
firefox-esr45 --- fixed

People

(Reporter: standard8, Assigned: mikedeboer)

References

Details

(Keywords: regression, Whiteboard: [btpp-fix-now])

Attachments

(2 files)

Looks like the push of bug  caused a frequent intermittent failures:

https://treeherder.mozilla.org/#/jobs?repo=fx-team&selectedJob=7053655

10:04:17     INFO -  85 INFO TEST-PASS | browser/base/content/test/chat/browser_chatwindow.js | Button should have been commanded once - 1 == 1 -
10:04:17     INFO -  86 INFO Finished chat test testCustomButton - cleaning up.
10:04:17     INFO -  87 INFO Leaving test
10:04:17     INFO -  88 INFO Console message: [JavaScript Error: "TypeError: content is null" {file: "chrome://browser/content/social-content.js" line: 62}]
10:04:17     INFO -  89 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/chat/browser_chatwindow.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -
10:04:17     INFO -  MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
10:04:17     INFO -  MEMORY STAT | vsize 681MB | residentFast 251MB | heapAllocated 84MB
10:04:17     INFO -  90 INFO TEST-OK | browser/base/content/test/chat/browser_chatwindow.js | took 46485ms

It looks like the test ran, but then failed at the end for some strange reason...

Probably Linux debug builds only.
https://hg.mozilla.org/integration/fx-team/rev/349a2612c171f29b445f4f8735b4450ae8b21f71
Bug 1245937 - Disable browser_chat_window.js for test failures frallout from bug 1154277. rs=orange-fix CLOSED TREE
I've marked the test as skipped for now, since I don't see an impact elsewhere, but we should probably fix this one as soon as we can.
Blocks: 1154277
Thanks Mark, for landing this follow-up so quickly! I will take this up tomorrow morning, first thing.
https://hg.mozilla.org/mozilla-central/rev/349a2612c171
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Whoops forgot the leave open
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Rank: 19
Depends on: 1229195
This was fixed by the patch in bug 1229195.
Comment on attachment 8718364 [details] [diff] [review]
Patch v1: re-enable browser_chatwindow.js mochitest

We don't need to wait for the loop part of bug 1229195 to land do we? Assuming not, then r=Standard8
Attachment #8718364 - Flags: review?(standard8) → review+
neup.
Mike: what's the status of this?
Flags: needinfo?(mdeboer)
Once bug 1229195 has landed, this test can be re-enabled after confirming things on Try.
Flags: needinfo?(mdeboer)
https://hg.mozilla.org/integration/fx-team/rev/6d20cb4a0dd85df647eb0e27c6c099d7439fd217
Bug 1245937 - requestLongerTimeout for browser_chatwindow.js and browser_focus.js since 1154277 slowed them down, transplanted from mozilla-aurora. rs=testonly
https://hg.mozilla.org/mozilla-central/rev/6d20cb4a0dd8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Mike, comment 17 seemed to transplant the requestLongerTimeout, but didn't actually re-land the enabling of the test?

Can you take a look please?
Status: RESOLVED → REOPENED
Flags: needinfo?(mdeboer)
Resolution: FIXED → ---
Ahum, you're entirely correct, sir.
Flags: needinfo?(mdeboer)
Status: REOPENED → ASSIGNED
Attachment #8728367 - Flags: review?(standard8)
Attachment #8728367 - Flags: review?(standard8) → review+
https://hg.mozilla.org/mozilla-central/rev/a437a0f043b6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.