1245937 - INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/chat/browser_chatwindow.js | This test exceeded the timeout threshold

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Looks like the push of bug  caused a frequent intermittent failures:

https://treeherder.mozilla.org/#/jobs?repo=fx-team&selectedJob=7053655

10:04:17     INFO -  85 INFO TEST-PASS | browser/base/content/test/chat/browser_chatwindow.js | Button should have been commanded once - 1 == 1 -
10:04:17     INFO -  86 INFO Finished chat test testCustomButton - cleaning up.
10:04:17     INFO -  87 INFO Leaving test
10:04:17     INFO -  88 INFO Console message: [JavaScript Error: "TypeError: content is null" {file: "chrome://browser/content/social-content.js" line: 62}]
10:04:17     INFO -  89 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/chat/browser_chatwindow.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -
10:04:17     INFO -  MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
10:04:17     INFO -  MEMORY STAT | vsize 681MB | residentFast 251MB | heapAllocated 84MB
10:04:17     INFO -  90 INFO TEST-OK | browser/base/content/test/chat/browser_chatwindow.js | took 46485ms

It looks like the test ran, but then failed at the end for some strange reason...

Probably Linux debug builds only.

Comment 1

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/349a2612c171f29b445f4f8735b4450ae8b21f71
Bug 1245937 - Disable browser_chat_window.js for test failures frallout from bug 1154277. rs=orange-fix CLOSED TREE

Comment 2

[Mark Banner (:standard8)]

I've marked the test as skipped for now, since I don't see an impact elsewhere, but we should probably fix this one as soon as we can.

Comment 3

[Mike de Boer [:mikedeboer]]

Thanks Mark, for landing this follow-up so quickly! I will take this up tomorrow morning, first thing.

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/349a2612c171

Comment 5

[Mark Banner (:standard8)]

Whoops forgot the leave open

Comment 6

[Mike de Boer [:mikedeboer]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8cb7d2497fef

Comment 7

[Mike de Boer [:mikedeboer]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ca73b7d53ab

Comment 8

[Mike de Boer [:mikedeboer]]

This was fixed by the patch in bug 1229195.

Comment 9

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: re-enable browser_chatwindow.js mochitest

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 8718364 [details] [diff] [review]
Patch v1: re-enable browser_chatwindow.js mochitest

We don't need to wait for the loop part of bug 1229195 to land do we? Assuming not, then r=Standard8

Comment 11

[Mike de Boer [:mikedeboer]]

neup.

Comment 12

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/integration/fx-team/rev/95d45bb51f96740972088720c0801d3d6035aaf6
Bug 1245937: re-enable browser_chatwindow.js mochitest. r=Standard8

Comment 13

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/fx-team/rev/95f3d3c8d595

https://treeherder.mozilla.org/logviewer.html#?job_id=7236107&repo=fx-team
https://treeherder.mozilla.org/logviewer.html#?job_id=7238398&repo=fx-team
https://treeherder.mozilla.org/logviewer.html#?job_id=7241182&repo=fx-team
https://treeherder.mozilla.org/logviewer.html#?job_id=7241493&repo=fx-team
https://treeherder.mozilla.org/logviewer.html#?job_id=7241430&repo=fx-team
https://treeherder.mozilla.org/logviewer.html#?job_id=7242428&repo=fx-team
https://treeherder.mozilla.org/logviewer.html#?job_id=7243322&repo=fx-team
https://treeherder.mozilla.org/logviewer.html#?job_id=7244267&repo=fx-team
https://treeherder.mozilla.org/logviewer.html#?job_id=7245843&repo=fx-team

Comment 14

[Ian Bicking (:ianbicking)]

Mike: what's the status of this?

Comment 15

[Mike de Boer [:mikedeboer]]

Once bug 1229195 has landed, this test can be re-enabled after confirming things on Try.

Comment 16

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/integration/fx-team/rev/6d20cb4a0dd85df647eb0e27c6c099d7439fd217
Bug 1245937 - requestLongerTimeout for browser_chatwindow.js and browser_focus.js since 1154277 slowed them down, transplanted from mozilla-aurora. rs=testonly

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6d20cb4a0dd8

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr45/rev/42d521310927

Comment 19

[Mark Banner (:standard8)]

Mike, comment 17 seemed to transplant the requestLongerTimeout, but didn't actually re-land the enabling of the test?

Can you take a look please?

Comment 20

[Mike de Boer [:mikedeboer]]

Ahum, you're entirely correct, sir.

Comment 21

[Mike de Boer [:mikedeboer]]

Attachment: Patch ad.: actually enable the test again

Comment 22

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/integration/fx-team/rev/a437a0f043b614c5cf05c4079b35fb696bf9168a
Bug 1245937: actually enable the test again. r=Standard8

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a437a0f043b6