Crash in LivemarkPayload.toMirrorItem

RESOLVED FIXED in 2.0

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rnewman, Assigned: rnewman)

Tracking

unspecified
All
iOS

Firefox Tracking Flags

(fxios2.0+)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
LivemarkPayload.toMirrorItem(UInt64) -> BookmarkMirrorItem (in Sync) (CleartextPayloadJSON.swift:41)
LivemarkPayload.toMirrorItem(UInt64) -> BookmarkMirrorItem (in Sync) (BookmarkPayload.swift:496)
protocol witness for MirrorItemable.toMirrorItem<A where ...>(UInt64) -> BookmarkMirrorItem in conformance LivemarkPayload (in Sync) (BookmarkPayload.swift:484)
BookmarksMirrorer.((applyRecordsFromBatcher in _CBD19FB4AE13E2D54D4F7F455AAFC646)(BookmarksMirrorer) -> () -> Deferred<Maybe<()>>).(closure #1) (in Sync) (BookmarksDownloader.swift:111)
thunk (in Sync) (BookmarksDownloader.swift:0)
specialized specialized SequenceType<A where ...>.flatMap<A><B where ...>((A.Generator.Element) throws -> B?) throws -> [B] (in Sync) (BookmarksDownloader.swift:0)
BookmarksMirrorer.(go(BookmarksMirrorer) -> (InfoCollections, greenLight : () -> Bool) -> Deferred<Maybe<()>>).(closure #1) (in Sync) (BookmarksDownloader.swift:111)
(Assignee)

Comment 1

3 years ago
            // TODO: these might need to be weakened if real-world data is dirty.
            parentID: self["parentid"].asString!,
            parentName: self["parentName"].asString!,
            title: self["title"].asString!,

Looks like real-world data is dirty!
(Assignee)

Comment 2

3 years ago
Created attachment 8716129 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1500
Attachment #8716129 - Flags: review?(sleroux)
(Assignee)

Updated

3 years ago
tracking-fxios: --- → 2.0+
Comment on attachment 8716129 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1500

LGTM!
Attachment #8716129 - Flags: review?(sleroux) → review+
(Assignee)

Comment 4

3 years ago
https://github.com/mozilla/firefox-ios/commit/876a5d90e6221fd252fc070704106e5bc7a2cf69
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0
You need to log in before you can comment on or make changes to this bug.