1245976 - Crash in LivemarkPayload.toMirrorItem

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, defect)

Description

[Richard Newman [:rnewman]]

LivemarkPayload.toMirrorItem(UInt64) -> BookmarkMirrorItem (in Sync) (CleartextPayloadJSON.swift:41)
LivemarkPayload.toMirrorItem(UInt64) -> BookmarkMirrorItem (in Sync) (BookmarkPayload.swift:496)
protocol witness for MirrorItemable.toMirrorItem<A where ...>(UInt64) -> BookmarkMirrorItem in conformance LivemarkPayload (in Sync) (BookmarkPayload.swift:484)
BookmarksMirrorer.((applyRecordsFromBatcher in _CBD19FB4AE13E2D54D4F7F455AAFC646)(BookmarksMirrorer) -> () -> Deferred<Maybe<()>>).(closure #1) (in Sync) (BookmarksDownloader.swift:111)
thunk (in Sync) (BookmarksDownloader.swift:0)
specialized specialized SequenceType<A where ...>.flatMap<A><B where ...>((A.Generator.Element) throws -> B?) throws -> [B] (in Sync) (BookmarksDownloader.swift:0)
BookmarksMirrorer.(go(BookmarksMirrorer) -> (InfoCollections, greenLight : () -> Bool) -> Deferred<Maybe<()>>).(closure #1) (in Sync) (BookmarksDownloader.swift:111)

Comment 1

[Richard Newman [:rnewman]]

            // TODO: these might need to be weakened if real-world data is dirty.
            parentID: self["parentid"].asString!,
            parentName: self["parentName"].asString!,
            title: self["title"].asString!,

Looks like real-world data is dirty!

Comment 2

[Richard Newman [:rnewman]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1500

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8716129 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1500

LGTM!

Comment 4

[Richard Newman [:rnewman]]

https://github.com/mozilla/firefox-ios/commit/876a5d90e6221fd252fc070704106e5bc7a2cf69