Create the parent map in the HeapAnalysesWorker

RESOLVED FIXED in Firefox 47

Status

DevTools
Memory
P2
normal
RESOLVED FIXED
2 years ago
7 days ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 47
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

I'm seeing fairly significant jank due to re-creating the parent map when fully re-rendering trees in the memory tool. Absolutely no good reason that this work isn't done in the HeapAnalysesWorker.
See Also: → bug 1246016
Ugh so I have a patch that implements this and it gets rid of a lot of jank on the main thread, but the additional worker traffic that is logged when we are testing is causing timeouts :(

Need to figure out how to fix that first.
Oh that was acutally really easy.
Created attachment 8716132 [details] [diff] [review]
Create the parent map in the HeapAnalysesWorker
Attachment #8716132 - Flags: review?(jimb)

Updated

2 years ago
Attachment #8716132 - Flags: review?(jimb) → review+
Keywords: checkin-needed
Depends on: 1246036
sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=7086078&repo=fx-team
Flags: needinfo?(nfitzgerald)
New try push rebased on fx-team: https://treeherder.mozilla.org/#/jobs?repo=try&revision=469a6b944e86
Flags: needinfo?(nfitzgerald)

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2a5f3b323a0f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47

Updated

7 days ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.