Closed Bug 1246017 Opened 7 years ago Closed 7 years ago

Create the parent map in the HeapAnalysesWorker

Categories

(DevTools :: Memory, defect, P2)

defect

Tracking

(firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I'm seeing fairly significant jank due to re-creating the parent map when fully re-rendering trees in the memory tool. Absolutely no good reason that this work isn't done in the HeapAnalysesWorker.
See Also: → 1246016
Ugh so I have a patch that implements this and it gets rid of a lot of jank on the main thread, but the additional worker traffic that is logged when we are testing is causing timeouts :(

Need to figure out how to fix that first.
Oh that was acutally really easy.
Attachment #8716132 - Flags: review?(jimb) → review+
Depends on: 1246036
sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=7086078&repo=fx-team
Flags: needinfo?(nfitzgerald)
New try push rebased on fx-team: https://treeherder.mozilla.org/#/jobs?repo=try&revision=469a6b944e86
Flags: needinfo?(nfitzgerald)
https://hg.mozilla.org/mozilla-central/rev/2a5f3b323a0f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.