1246095 - Warning triangle from “Some extensions could not be verified” button misses or is incorrectly displayed

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

[Note]:
This is a follow-up for Bug  1172835

[Affected versions]:
Firefox 47.0a1 (2016-02-04)

{Affected platforms]:
Windows 10 64-bit
Ubuntu 14.04 32-bit
Ubuntu 13.10 64-bit

STR
1.Launch Firefox with clean profile.
2.Navigate to about:config and set xpinstall.signatures.required to false.
3.Restart the browser.
4.Install an add-on from https://addons.allizom.org/en-US/firefox/ .
5.Enable xpinstall.signatures.required from about:config.
6.Restart the browser.
7.Open about:addons. 

ER
The warning triangle is correctly displayed on “Some extensions could not be verified” button as it appears for Mac platforms: http://i.imgur.com/yswxNw8.png

AR
[1] Windows 10 64-bit - there is no space between the triangle and the “Some” word: http://i.imgur.com/89fRCZq.jpg 
[2] Ubuntu 14.04 32-bit and Ubuntu 13.10 64-bit - the triangle misses from the button  http://i.imgur.com/Fpp1YDu.png

[Additional notes]:
This issue is not reproducible using Mac platforms.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: Correct list-style-position css typo

There is a typo in the original patch. Not sure if this causes it. I just noticed it in the Seamonkey error console and so can't verify if it fixes the problems in Firefox.

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8719147 [details] [diff] [review]
Correct list-style-position css typo

Review of attachment 8719147 [details] [diff] [review]:
-----------------------------------------------------------------

It isn't that rule that is broken, and the fact it's broken means we should probably just remove it!

Comment 3

[Dave Townsend [:mossop]]

The problem here is this linux specific rule:

https://dxr.mozilla.org/mozilla-central/source/toolkit/content/xul.css#118

It seems to be saying that in certain OS configurations we don't show icons in buttons generally. We can override that here but we should verify with UX if that is the right thing to do.

Markus, what say you?

Comment 4

[Markus Jaritz [:designakt] (UX)]

I do not know of this rule of hiding icons in buttons on certain OS configurations.
Without knowing why it is in place I do not think we should override it.

Great that you caught that misalignment in Windows.

Comment 5

[Andrew Swan [:aswan]]

So I assume we're leaving the Mac portion of this bug as "won't fix".  As for the alignment on Windows, I think this comes from the differences between css rules for margins on button-text on the two platforms:
https://dxr.mozilla.org/mozilla-central/rev/d848a5628d801a460a7244cbcdea22d328d8b310/toolkit/themes/windows/global/button.css#36
https://dxr.mozilla.org/mozilla-central/rev/d848a5628d801a460a7244cbcdea22d328d8b310/toolkit/themes/osx/global/button.css#34

Changing the platform-wide settings there is almost certainly wrong, but I'm not sure why the difference exists in the first place.  Dave, any suggestions for where to go next?

Comment 6

[Dave Townsend [:mossop]]

(In reply to Andrew Swan [:aswan] from comment #5)
> So I assume we're leaving the Mac portion of this bug as "won't fix".  As
> for the alignment on Windows, I think this comes from the differences
> between css rules for margins on button-text on the two platforms:
> https://dxr.mozilla.org/mozilla-central/rev/
> d848a5628d801a460a7244cbcdea22d328d8b310/toolkit/themes/windows/global/
> button.css#36
> https://dxr.mozilla.org/mozilla-central/rev/
> d848a5628d801a460a7244cbcdea22d328d8b310/toolkit/themes/osx/global/button.
> css#34
> 
> Changing the platform-wide settings there is almost certainly wrong, but I'm
> not sure why the difference exists in the first place.  Dave, any
> suggestions for where to go next?

You could ask dao why the difference is there, but either way the fix is just to apply a margin change to this specific button.

Comment 7

[Andrew Swan [:aswan]]

Attachment: MozReview Request: Bug 1246095 - Put explicit margins on "Some extensions could not be verified" button r?mossop

Review commit: https://reviewboard.mozilla.org/r/36507/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36507/

Comment 8

[Dave Townsend [:mossop]]

Comment on attachment 8723374 [details]
MozReview Request: Bug 1246095 - Put explicit margins on "Some extensions could not be verified" button r?mossop

https://reviewboard.mozilla.org/r/36507/#review33159

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6ed7e3cfe31c

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6ed7e3cfe31c

Comment 11

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

I've managed to reproduce the bug on the affected build, using Windows 10 x64, Ubuntu 14.04 x86 and Ubuntu 12.04 x64. Also, I confirm that Mac platform isn`t affected. 

This is verified fixed on Windows 10 x64 using:
 - 47.0a2 (2016-04-04)
 - 48.0a1 (2016-04-04)

Note: Unfortunately, this issue is still reproducible on Ubuntu 14.04 x86 and 12.04 x64.  In my verification process I`ve used the user story. What part of the described issue is supposed to be fixed by the applied patch?

Comment 12

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

ni?

Comment 13

[Andrew Swan [:aswan]]

See comment 4, I understood that comment to mean "lets not display the image on Linux, since that is the standard on that platform"

Comment 14

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

(In reply to Andrew Swan [:aswan] from comment #13)
> See comment 4, I understood that comment to mean "lets not display the image
> on Linux, since that is the standard on that platform"

Thank you for your clarification! Considering what has already been said, I think that the issue deserves the verified fixed status.