Closed
Bug 1246100
Opened 8 years ago
Closed 8 years ago
[Static Analysis][Big parameter passed by value] In Function MockWebBrowserPrint
Categories
(Core Graveyard :: Embedding: APIs, defect)
Core Graveyard
Embedding: APIs
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: andi, Assigned: andi)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1286525)
Attachments
(1 file)
1.83 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
The Static Analysis tool Coverity added aData is passed to contructor MockWebBrowserPrint by value: >> explicit MockWebBrowserPrint(const PrintData aData); The size of PrintData is around 560 bytes, more or less depending on platform data alignment. We could modify this by passing aData as PrintData& and than passing it to mData that calls the copy constructor: >> MOZ_IMPLICIT PrintData(const PrintData& _o) Thus we can avoid the first copy of PrinData on the stack of MockWebBrowserPrint's constructor.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8716217 -
Flags: review?(benjamin)
Updated•8 years ago
|
Attachment #8716217 -
Flags: review?(benjamin) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4f4f57c87427
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•