Closed Bug 1246106 Opened 4 years ago Closed 4 years ago

[Static Analysis][Big parameter passed by value] In Function ComputeBorderOverflow

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1225484 )

Attachments

(1 file, 1 obsolete file)

The Static Analysis tool Coverity added that parameter aStyleBorder is passed as value. This is performance inefficient since it's around 312 bytes depending on platform data alignment. We can pass this as a pointer.
Comment on attachment 8716229 [details] [diff] [review]
pass aStyleBorder as pointer to ComputeBorderOverflow

I think "const nsStyleBorder& aStyleBorder" is preferred.

r=mats with that change.
Attachment #8716229 - Flags: review?(roc) → review+
Attached patch Bug 1246106.diffSplinter Review
Attachment #8716229 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7b7110c017c5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.