1246124 - McAfee SiteAdvisor extension wipes out Add-ons/Extensions page

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Andreas Troschka]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20160123151951

Steps to reproduce:

Windows 10 Pro Build10586.
McAfee product LiveSafe autoupdated. 
The plugin C:\Program Files (x86)\McAfee\SiteAdvisor\saffplg.xpi v4.0.20 is now installed.

Opened Add-ons, then Extensions.


Actual results:

Despite plugins are already present (some are visible on the toolbar) and are functioning, they are no more shown in the Extensions page, making it impossible to manage them in any way.



Expected results:

Normal listing of plugins.


Note: Renaming the file saffplg.xpi and restarting FF removes the SiteAdvisor functionality but the Extensions page is again populated with the (DISABLED!) plugins list. Reenabling them restores the situation.

Comment 1

[Loic]

I guess this add-on uses some CSS hacks to hide itself in the add-on manager, against the rules.

Comment 2

[Andreas Troschka]

This maybe an issue due to the McAfee's saffplg.xpi plugin itself.

Comment 3

[Dave Townsend [:mossop]]

Can you attach the XPI file to this bug report?

Comment 4

[Andreas Troschka]

Attachment: McAfee plugin

Comment 5

[Tony Mechelynck [:tonymec]]

N.B. (@Andreas) In Mozilla terminology, a "plugin" or an "NPAPI plugin" is the kind of stuff listed in the Plugins pane of the add-ons manager, or in about:plugins (Flash is an example). XPI files can be extensions, themes, language packs, or in general "add-ons" but not plugins.

Comment 6

[Tony Mechelynck [:tonymec]]

Hm... Is there a Product/Component for McAfee Site Advisor bugs? Not sure if "Plugins / McAfee AV" qualifies.

Comment 7

[:shell escalante]

Jorge, can you take a look and see what this add-on is doing that is off?

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

I don't see anything in the add-on code specifically targeting the Add-ons Manager. The code is minified though, so I could be wrong. There's some CSS manipulation happening, so there could be a bug in the way that is applied. I couldn't reproduce the bug by installing the xpi on Mac OS.

I'll contact the developers about this.

Comment 9

[Anu]

We will check the issue. There is nothing done in the plug-in targeting Add-ons Manager or to hide from Add-on manager.

Comment 10

[:shell escalante]

Krupa will try to replicate on windows 10 -

Comment 11

[Valentina Virlics [:vvalentina], Ecosystem QA]

Verified this on:
1) User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20160120154102
&
2) User Agent  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID  20160123151951

and could not reproduce it.

Downloaded the attached .xpi and submitted using AMO-stage. 
You can see the extension here: https://addons.allizom.org/en-US/firefox/addon/mcafee-webadvisor/

Results after installation of "McAfee WebAdvisor":
- the extension is listed in about:addons Extensions pane (http://screencast.com/t/vwXhyeJ9Jo)
- details about the extension can be seen (http://screencast.com/t/du6lt6Ax66)
- installing other add-ons (normal add-ons, webextensions) does not brake the extension or the discovery pane
- restarting the FF browser has the expected behavior

Please let us now if there is some other step that we missed in order to reproduce this.

Comment 12

[Jorge Villalobos [:jorgev] (he/him)]

Closing this due to lack of reliable STR.

@Andreas Troschka: if you have more detailed steps we can try, please post them here and we will reopen the bug.

Comment 13

[Andreas Troschka]

Looking at Windows' update logs I found something suspicious. Around the same time FF started to show the washed extension page, object of this bug, a Windows auto-update was performed.
So I've decided to make a test.

a) Fresh install of Windows 10 Pro, updated as at time FF showed the malfunction;
b) On another partition fresh install of Windows and full update to actual version.

FF and McAfee extension (versions as mentioned in this thread) installed on both partitions.

Results:

a) Extension page in FF washed as mentioned;
b) FF works as expected; extension page shows the Mcafee extension (the only installed) as it should do.

I've no clue what the problem is, therefore it appears that something, in the older update setup (build) of Windows 10 triggers the misbehaviour in FF.

As the problem is disappeared with the Windows last update, I would consider this bug solved.

Thank's to all for the efforts.

Andreas Troschka