1246127 - mach build-backend --backend=VisualStudio generates wrong 32-bit VS2013 solution when it was expected to create a 64-bit VS2015 solution.

Status: NEW

(Firefox Build System :: General, defect)

Description

[Jukka Jylänki]

STR:

1. Download and install Mozillabuild at https://ftp.mozilla.org/pub/mozilla.org/mozilla/libraries/win32/MozillaBuildSetup-Latest.exe
2. Launch start-shell-msvc2015-x64.bat in mozilla-build directory
3. Clone mozilla-central and navigate to its root directory
4. Run ./mach build-backend --backend==VisualStudio
5. Open solution

Observed: The generated obj-x86_64-pc-mingw32\msvc\mozilla.sln file is for Visual Studio 2013 and it has solution platform of "Win32" indicating 32-bit.

Expected: Since mozilla-build has .bat files for start-shell-msvc2013.bat, start-shell-msvc2013-x64.bat, start-shell-msvc2015.bat and start-shell-msvc2015-x64.bat, and because of step 2 and due to the command line on step 4 not specifying a particular Visual Studio version, the expectation is that the generated solution file should be for Visual Studio 2015 and it should have solution platform "x64" indicating 64-bit. Is that a correct expectation?

Comment 1

[(not currently active) Ted Mielczarek]

The VS backend is hard-coded to generate VS2013 project files right now:
https://dxr.mozilla.org/mozilla-central/rev/584870f1cbc5d060a57e147ce249f736956e2b62/python/mozbuild/mozbuild/backend/visualstudio.py#96

There's a comment there about how that should be configurable, but it needs testing.

It's also hard-coded to generate a Win32 configuration:
https://dxr.mozilla.org/mozilla-central/rev/584870f1cbc5d060a57e147ce249f736956e2b62/python/mozbuild/mozbuild/backend/visualstudio.py#330

That's probably not that hard to fix, we could just check the target cpu and set it appropriately.