1246138 - The account picture is wrongly displayed when trying to upload a photo from the firstrun page

Status: RESOLVED FIXED

(Cloud Services :: Server: Firefox Accounts, defect)

Description

[Mihai Boldan, Desktop QA [:mboldan]]

Attachment: account photo.png

[Affected versions]:
Firefox 45.0b3, Firefox 44.0.1 RC

[Affected platforms]:
Windows 10 x86, Ubuntu 12.04 x86 and Mac OS X 10.11.1 

[Steps to reproduce]:
1. Launch Firefox browser and Sign in with a Firefox Account.
2. Go to https://www.mozilla.org/en-US/firefox/45.0/firstrun/ and select the 'Add' button from Account picture.
3. Select the Upload button and open an available photo.

[Expected result]:
The selected photo is correctly displayed.

[Actual result]:
The photo is not centered and a black frame is displayed on the sides.(see the attached scrrenshot) 

[Additional notes]:
This issue is not reproducible on Latest Nightly and Latest Aurora because the first run page does not contain Sign in to Sync pop up.

Comment 1

[YF (Yang)]

https://github.com/mozilla/fxa-content-server/blob/16c9fd54962e44292ec94a4305399bcacfa2d3cb/app/styles/modules/_cropper.scss

Modify the -30px to -60px looks centered to me, on https://www.mozilla.org/en-US/firefox/45.0/firstrun/ in Fx45b3.

Disalbe the "background-color: $cropper-background-color;" will remove the black frame and keep the translucent mask, but I don't know its aftermath.

Comment 2

[Ryan Kelly [:rfkelly]]

I'm able to reproduce when accessing https://accounts.firefox.com/settings directly, but making the screen short.  Hopefully just a simple styling issue as YF suggests.  I've escalated to this bug in the Firefox Accounts repo: https://github.com/mozilla/fxa-content-server/issues/3485

Comment 3

[Wil Clouser [:clouserw]]

This was fixed in https://github.com/mozilla/fxa/pull/4463