1246147 - Unexpected error displayed for a second when signing into FxA

Status: RESOLVED FIXED

(Cloud Services :: Server: Firefox Accounts, defect)

Description

[Ada [:adalucinet]]

Attachment: Screenshot.png

Affected versions: 45 beta 3 (Build ID: 20160204142810), latest Aurora 46.0a2 and Nightly 47.0a1 (from 2016-02-04)
Affected platforms: Windows 7 x64, Mac OS X 10.8, Ubuntu 12.04 x86, Windows 10 x86

Steps to reproduce:
Prequisite: Existing Firefox account.
1. Launch Firefox with a clean profile
2. Click on one of the available Sync buttons (e.g. about:home, about:preferences#sync, menu panel, Tools).
3. Sign in with an existing account.	

Expected result: No errors displayed when signing in.

Actual result: An Unexpected error prompt is displayed for a second before the user is signed in.

Additional notes:
1. NOTE: on Windows 7 x64 this issue is reproducible only with 64-bit builds.
2. Screenshot attached.
3. Browser console output: 'Unexpected error' thrown by 1993ee03.main.js:18:24598
4. Regression range:
Last good Nightly: 2015-11-26
First bad Nightly: 2015-11-25
Pushlog: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=31cf031ca23e4927db55f9e5469ac3e4c6599a35&tochange=80cc747d4e5e64f9e37e2eba98be52fcc772ad19

Comment 1

[Robert Kaiser]

[Tracking Requested - why for this release]:
Regression in 45, in a feature (FxA) that we really do not want to look bad.

Comment 2

[Ryan Kelly [:rfkelly]]

The most obvious suspect in the linked pushlog is: "Bug 1218022 - switch to fx_desktop_v2 context for Firefox Accounts."

I was able to reproduce on my Mac using current DevEdition.

Comment 3

[Ryan Kelly [:rfkelly]]

> I was able to reproduce on my Mac using current DevEdition.

And I can do so by signing out and singing back in rather than having to start from a fresh profile.

Comment 4

[Ryan Kelly [:rfkelly]]

Possible related to and/or fixed by the changes to fxa_desktop_v2 here?
https://github.com/mozilla/fxa-content-server/pull/3442

Comment 5

[Ryan Kelly [:rfkelly]]

Yes, looks like a dupe of https://github.com/mozilla/fxa-content-server/issues/3353 which should be fixed with next FxA server deployment.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Ryan, do you confirm that it is fixed?
Tracking to make sure we address the issue if it is not actually fixed.

Comment 7

[Ryan Kelly [:rfkelly]]

The fix is not in production yet, but should go live this week; leaving ni? myself to confirm when it's deployed

Comment 8

[Ryan Kelly [:rfkelly]]

The fix for this is now live, so closing this out, please re-open if the error still occurs.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Server side, updating the status flags accordingly.