Closed Bug 1246151 Opened 8 years ago Closed 8 years ago

symbols.mo should not rewrite requests for /firefox/<guid>/firefox.*

Categories

(Socorro :: Infra, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ted, Assigned: ted)

Details

Attachments

(1 file)

This has bugged me for a while now. Since we stuffed all the symbols in a flat namespace in S3, it's possible to use "http://symbols.mozilla.org/" as a symbol server URL. However, when you're trying to fetch symbols for the `firefox` binary on Linux or Mac, you wind up requesting a URL like `http://symbols.mozilla.org/firefox/946C0C63132015DD88CA2EFCBB9AC4C70/firefox.sym`, which gets rewritten to `http://symbols.mozilla.org/946C0C63132015DD88CA2EFCBB9AC4C70/firefox.sym` and then again to the S3 bucket and then it 404s.

This isn't a problem for Socorro since the processors use the actual S3 bucket URL and don't hit the rewrites, but it's nice to be able to use the human-friendly URL.

I have a patch.
Attached file fix rewrites
Attachment #8716301 - Flags: review?(rhelmer)
Attachment #8716301 - Flags: review?(rhelmer) → review+
Merged this and fixed the github->travis->heroku autodeploy (needed a new token), so this is deployed:

$ python test.py http://symbols.mozilla.org
........
----------------------------------------------------------------------
Ran 8 tests in 8.880s

OK
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: