Closed
Bug 1246160
Opened 7 years ago
Closed 7 years ago
Bookmark this Tab doesn’t work
Categories
(Firefox :: Sync, defect)
Tracking
()
VERIFIED
FIXED
Firefox 47
Tracking | Status | |
---|---|---|
firefox44 | --- | unaffected |
firefox45 | --- | unaffected |
firefox46 | --- | unaffected |
firefox47 | --- | verified |
People
(Reporter: vtamas, Assigned: eoger)
References
Details
(Whiteboard: [bugday-20160224])
Attachments
(1 file)
1.84 KB,
patch
|
zaach
:
review+
|
Details | Diff | Splinter Review |
[Affected versions]: Firefox 47.0a1 (2016-02-04) [Affected platforms]: Ubuntu 14.04 32-bit Windows 10 64-bit Mac OS X 10.11.1 STR 1.Launch Firefox with clean profile. 2.Click menu [≡] → Synced tabs → Sign in to sync. 3.Login using a Firefox account 4.Click menu [≡] → Synced tabs → View synced tabs sidebar. 5.Right click on one of the tabs from the list. 6.Select “Bookmark This Tab” ER The Synced tab is successfully saved as bookmark. AR - The selected Synced tab is not saved as bookmark. - The following error is thrown in Browser Console: TypeError: this._window.PlacesUtils is undefined TabListComponent.js:103:1
Assignee | ||
Comment 1•7 years ago
|
||
I also fixed the test. (hey Zach!)
Assignee: nobody → edouard.oger
Status: NEW → ASSIGNED
Attachment #8716323 -
Flags: review?(zack.carter)
Comment 2•7 years ago
|
||
Comment on attachment 8716323 [details] [diff] [review] bug-1246160.patch Review of attachment 8716323 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Edouard!
Attachment #8716323 -
Flags: review?(zack.carter) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2ab89a7853ce
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Reporter | ||
Updated•7 years ago
|
Flags: qe-verify+
Comment 5•7 years ago
|
||
I have reproduced this bug on Nightly 47.0a1 (2016-02-05) on ubuntu 14.04 LTS, 32 bit! The bug's fix is now verified on Latest Nightly 47.0a1! Build ID: 20160211030242 User Agent: Mozilla/5.0 (X11; Linux i686; rv:47.0) Gecko/20100101 Firefox/47.0
QA Whiteboard: [bugday-20160210]
Comment 6•6 years ago
|
||
I have reproduced this bug with Firefox Nightly 47.0a1 (Build ID: 20160205030204) on windows 8.1, 64-bit with the instructions from comment 0. Verified as fixed with latest Firefox Nightly 47.0a1 (Build ID: 20160226030256) Mozilla/5.0 (Windows NT 6.3; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0 As this bug is also verified on Linux(Comment 5), I am marking this as verified!
You need to log in
before you can comment on or make changes to this bug.
Description
•