1246160 - Bookmark this Tab doesn’t work

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

[Affected versions]:
Firefox 47.0a1 (2016-02-04)

[Affected platforms]:
Ubuntu 14.04 32-bit
Windows 10 64-bit
Mac OS X 10.11.1

STR
1.Launch Firefox with clean profile.
2.Click menu [≡] → Synced tabs  → Sign in to sync.
3.Login using a Firefox account
4.Click menu [≡] → Synced tabs  → View synced tabs sidebar.
5.Right click on one of the tabs from the list.
6.Select “Bookmark This Tab”


ER
The Synced tab is successfully saved as bookmark.


AR
- The selected Synced tab is not saved as bookmark.
- The following error is thrown in Browser Console:
TypeError: this._window.PlacesUtils is undefined TabListComponent.js:103:1

Comment 1

[Edouard Oger [:eoger]]

Attachment: bug-1246160.patch

I also fixed the test. (hey Zach!)

Comment 2

[Zachary Carter [:zaach]]

Comment on attachment 8716323 [details] [diff] [review]
bug-1246160.patch

Review of attachment 8716323 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Edouard!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2ab89a7853ce

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2ab89a7853ce

Comment 5

[Khalid Syfullah Zaman [:khalid32]]

I have reproduced this bug on Nightly 47.0a1 (2016-02-05) on ubuntu 14.04 LTS, 32 bit!

The bug's fix is now verified on Latest Nightly 47.0a1!

Build ID: 20160211030242
User Agent: Mozilla/5.0 (X11; Linux i686; rv:47.0) Gecko/20100101 Firefox/47.0

Comment 6

[Mohammad Maruf Islam]

I have reproduced this bug with Firefox Nightly 47.0a1 (Build ID: 20160205030204) on 
windows 8.1, 64-bit with the instructions from comment 0.

Verified as fixed with latest Firefox Nightly 47.0a1 (Build ID: 20160226030256)
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0

As this bug is also verified on Linux(Comment 5), I am marking this as verified!