Closed Bug 1246227 Opened 4 years ago Closed 4 years ago

Remove SEC_NORMAL from dom/base/test

Categories

(Core :: DOM: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: ckerschb, Assigned: mwobensmith)

References

Details

Attachments

(1 file, 2 obsolete files)

We should use NetUtil.newChannel({uri: [url], loadUsingSystemPrincipal)} in all of the following tests:

/dom/base/test/test_bug422403-1.html (View Hg log or Hg annotations)
/dom/base/test/test_bug422403-2.xhtml (View Hg log or Hg annotations)
/dom/base/test/test_bug424359-1.html (View Hg log or Hg annotations)
/dom/base/test/test_bug424359-2.html (View Hg log or Hg annotations)
/dom/base/test/test_bug498433.html (View Hg log or Hg annotations)
Blocks: 1182535
This should actually block the dom-tracking bug, not the main tracking bug.
Blocks: 1232430
No longer blocks: 1182535
Assignee: nobody → mwobensmith
Status: NEW → ASSIGNED
Attached patch bug1246227.patch (obsolete) — Splinter Review
Attachment #8718112 - Flags: review?(mozilla)
As per Christoph, we made the decision to instead substitute SEC_NORMAL with SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL, due to another issue with the proposed change in comment 0. 

Also, these files needed to be modified to use open2 instead of open.
Comment on attachment 8718112 [details] [diff] [review]
bug1246227.patch

Review of attachment 8718112 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, thanks Matt!

::: dom/base/test/test_bug422403-1.html
@@ +27,5 @@
>      baseUri.spec = window.location.href;
>  
>      var ios = SpecialPowers.Cc['@mozilla.org/network/io-service;1']
>              .getService(SpecialPowers.Ci.nsIIOService);
> +

It seems something is off with your line-endings, can you double check before landing?

@@ +197,5 @@
>  
>  </script>
>  </pre>
>  </body>
>  </html>

same here!
Attachment #8718112 - Flags: review?(mozilla) → review+
Attached patch bug1246227.patch (obsolete) — Splinter Review
Reverted unwanted line changes.
Attachment #8718112 - Attachment is obsolete: true
Attachment #8718133 - Flags: review?(mozilla)
Attached patch bug1246227.patchSplinter Review
One last attempt at correcting unwanted line changes.
Attachment #8718133 - Attachment is obsolete: true
Attachment #8718133 - Flags: review?(mozilla)
Attachment #8718135 - Flags: review?(mozilla)
Comment on attachment 8718135 [details] [diff] [review]
bug1246227.patch

Review of attachment 8718135 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8718135 - Flags: review?(mozilla) → review+
failed to apply:

applying bug1246227.patch
patching file dom/base/test/test_bug422403-1.html
Hunk #1 FAILED at 11
1 out of 1 hunks FAILED -- saving rejects to file dom/base/test/test_bug422403-1.html.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh bug1246227.patch
Flags: needinfo?(mwobensmith)
Keywords: checkin-needed
(In reply to Pulsebot from comment #9)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/0bd347e9acfc

Rebased and pushed.
Flags: needinfo?(mwobensmith)
https://hg.mozilla.org/mozilla-central/rev/0bd347e9acfc
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.