Closed
Bug 1246227
Opened 8 years ago
Closed 8 years ago
Remove SEC_NORMAL from dom/base/test
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: ckerschb, Assigned: mwobensmith)
References
Details
Attachments
(1 file, 2 obsolete files)
8.34 KB,
patch
|
ckerschb
:
review+
|
Details | Diff | Splinter Review |
We should use NetUtil.newChannel({uri: [url], loadUsingSystemPrincipal)} in all of the following tests: /dom/base/test/test_bug422403-1.html (View Hg log or Hg annotations) /dom/base/test/test_bug422403-2.xhtml (View Hg log or Hg annotations) /dom/base/test/test_bug424359-1.html (View Hg log or Hg annotations) /dom/base/test/test_bug424359-2.html (View Hg log or Hg annotations) /dom/base/test/test_bug498433.html (View Hg log or Hg annotations)
Reporter | ||
Comment 1•8 years ago
|
||
This should actually block the dom-tracking bug, not the main tracking bug.
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → mwobensmith
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8718112 -
Flags: review?(mozilla)
Assignee | ||
Comment 3•8 years ago
|
||
As per Christoph, we made the decision to instead substitute SEC_NORMAL with SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL, due to another issue with the proposed change in comment 0. Also, these files needed to be modified to use open2 instead of open.
Reporter | ||
Comment 4•8 years ago
|
||
Comment on attachment 8718112 [details] [diff] [review] bug1246227.patch Review of attachment 8718112 [details] [diff] [review]: ----------------------------------------------------------------- Awesome, thanks Matt! ::: dom/base/test/test_bug422403-1.html @@ +27,5 @@ > baseUri.spec = window.location.href; > > var ios = SpecialPowers.Cc['@mozilla.org/network/io-service;1'] > .getService(SpecialPowers.Ci.nsIIOService); > + It seems something is off with your line-endings, can you double check before landing? @@ +197,5 @@ > > </script> > </pre> > </body> > </html> same here!
Attachment #8718112 -
Flags: review?(mozilla) → review+
Assignee | ||
Comment 5•8 years ago
|
||
hide |
Reverted unwanted line changes.
Attachment #8718112 -
Attachment is obsolete: true
Attachment #8718133 -
Flags: review?(mozilla)
Assignee | ||
Comment 6•8 years ago
|
||
One last attempt at correcting unwanted line changes.
Attachment #8718133 -
Attachment is obsolete: true
Attachment #8718133 -
Flags: review?(mozilla)
Attachment #8718135 -
Flags: review?(mozilla)
Reporter | ||
Comment 7•8 years ago
|
||
Comment on attachment 8718135 [details] [diff] [review] bug1246227.patch Review of attachment 8718135 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8718135 -
Flags: review?(mozilla) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 8•8 years ago
|
||
failed to apply: applying bug1246227.patch patching file dom/base/test/test_bug422403-1.html Hunk #1 FAILED at 11 1 out of 1 hunks FAILED -- saving rejects to file dom/base/test/test_bug422403-1.html.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory errors during apply, please fix and qrefresh bug1246227.patch
Flags: needinfo?(mwobensmith)
Keywords: checkin-needed
Reporter | ||
Comment 10•8 years ago
|
||
(In reply to Pulsebot from comment #9) > https://hg.mozilla.org/integration/mozilla-inbound/rev/0bd347e9acfc Rebased and pushed.
Flags: needinfo?(mwobensmith)
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0bd347e9acfc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•