1246227 - Remove SEC_NORMAL from dom/base/test

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Christoph Kerschbaumer [:ckerschb}]

We should use NetUtil.newChannel({uri: [url], loadUsingSystemPrincipal)} in all of the following tests:

/dom/base/test/test_bug422403-1.html (View Hg log or Hg annotations)
/dom/base/test/test_bug422403-2.xhtml (View Hg log or Hg annotations)
/dom/base/test/test_bug424359-1.html (View Hg log or Hg annotations)
/dom/base/test/test_bug424359-2.html (View Hg log or Hg annotations)
/dom/base/test/test_bug498433.html (View Hg log or Hg annotations)

Comment 1

[Christoph Kerschbaumer [:ckerschb}]

This should actually block the dom-tracking bug, not the main tracking bug.

Comment 2

[Matt Wobensmith [:mwobensmith][:matt:]]

Attachment: bug1246227.patch

Comment 3

[Matt Wobensmith [:mwobensmith][:matt:]]

As per Christoph, we made the decision to instead substitute SEC_NORMAL with SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL, due to another issue with the proposed change in comment 0. 

Also, these files needed to be modified to use open2 instead of open.

Comment 4

[Christoph Kerschbaumer [:ckerschb}]

Comment on attachment 8718112 [details] [diff] [review]
bug1246227.patch

Review of attachment 8718112 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, thanks Matt!

::: dom/base/test/test_bug422403-1.html
@@ +27,5 @@
>      baseUri.spec = window.location.href;
>  
>      var ios = SpecialPowers.Cc['@mozilla.org/network/io-service;1']
>              .getService(SpecialPowers.Ci.nsIIOService);
> +

It seems something is off with your line-endings, can you double check before landing?

@@ +197,5 @@
>  
>  </script>
>  </pre>
>  </body>
>  </html>

same here!

Comment 5

[Matt Wobensmith [:mwobensmith][:matt:]]

Attachment: bug1246227.patch

Reverted unwanted line changes.

Comment 6

[Matt Wobensmith [:mwobensmith][:matt:]]

Attachment: bug1246227.patch

One last attempt at correcting unwanted line changes.

Comment 7

[Christoph Kerschbaumer [:ckerschb}]

Comment on attachment 8718135 [details] [diff] [review]
bug1246227.patch

Review of attachment 8718135 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 8

[Carsten Book [:Tomcat]]

failed to apply:

applying bug1246227.patch
patching file dom/base/test/test_bug422403-1.html
Hunk #1 FAILED at 11
1 out of 1 hunks FAILED -- saving rejects to file dom/base/test/test_bug422403-1.html.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh bug1246227.patch

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0bd347e9acfc

Comment 10

[Christoph Kerschbaumer [:ckerschb}]

(In reply to Pulsebot from comment #9)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/0bd347e9acfc

Rebased and pushed.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0bd347e9acfc