Fix "warning: destructor called on non-final 'Foo' that has virtual functions but non-virtual destructor"

RESOLVED WORKSFORME

Status

()

Core
JavaScript: GC
RESOLVED WORKSFORME
3 years ago
2 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox47 affected)

Details

(Assignee)

Description

3 years ago
These started showing up in large volumes when I upgraded. Mostly these are CustomAutoRooters. I've been meaning to replace that infrastructure anyway, now that we can just use Rooted with basically anything.
(Assignee)

Comment 1

2 years ago
I think this was a compiler bug: when I updated to the 3.8 release these warning went away.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WORKSFORME

Comment 2

2 years ago
It's more likely that the compiler stopped warning when the class in question was marked final.  We've been adding final to more things lately, partly to kill off this warning, and that's probably made the difference.
You need to log in before you can comment on or make changes to this bug.