Closed Bug 1246285 Opened 8 years ago Closed 8 years ago

mozreview: mark the review git remote to skip fetches

Categories

(MozReview Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rillian, Assigned: rillian)

Details

Attachments

(1 file)

By default, `git remote update` will fetch every repo, which is a bad idea with the review repo, and in any case doesn't work currently.
Mark the repo with 'skipDefaultUpdate' when git-mozreview configure` creates it to avoid this.
Assignee: nobody → giles
Attachment #8716473 - Flags: review?(gps)
Comment on attachment 8716473 [details] [diff] [review]
Mark remote with skipDefaultUpdate

Review of attachment 8716473 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, there is also a "skipFetchAll" option. However, Git's man page is not very helpful:

       remote.<name>.skipDefaultUpdate
           If true, this remote will be skipped by default when updating using git-fetch(1) or the update subcommand of git-remote(1).

       remote.<name>.skipFetchAll
           If true, this remote will be skipped by default when updating using git-fetch(1) or the update subcommand of git-remote(1).


I'm not sure if these are literally aliases to each other or what.
Attachment #8716473 - Flags: review?(gps) → review+
They treated identically as far as I can see. This is the only occurance: https://github.com/git/git/blob/master/remote.c#L381

skipDefaultUpdate seems more appropriate. 'git fetch' takes a specific remote, so having that fail when fetch is specifically requested is less surprising.
Keywords: checkin-needed
Note, that's partly why I said it would have been better to not add a remote...
Status: NEW → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: