Closed
Bug 1246285
Opened 8 years ago
Closed 8 years ago
mozreview: mark the review git remote to skip fetches
Categories
(MozReview Graveyard :: General, defect)
MozReview Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rillian, Assigned: rillian)
Details
Attachments
(1 file)
1.71 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
By default, `git remote update` will fetch every repo, which is a bad idea with the review repo, and in any case doesn't work currently.
Assignee | ||
Comment 1•8 years ago
|
||
Mark the repo with 'skipDefaultUpdate' when git-mozreview configure` creates it to avoid this.
Assignee: nobody → giles
Attachment #8716473 -
Flags: review?(gps)
Comment 2•8 years ago
|
||
Comment on attachment 8716473 [details] [diff] [review] Mark remote with skipDefaultUpdate Review of attachment 8716473 [details] [diff] [review]: ----------------------------------------------------------------- FWIW, there is also a "skipFetchAll" option. However, Git's man page is not very helpful: remote.<name>.skipDefaultUpdate If true, this remote will be skipped by default when updating using git-fetch(1) or the update subcommand of git-remote(1). remote.<name>.skipFetchAll If true, this remote will be skipped by default when updating using git-fetch(1) or the update subcommand of git-remote(1). I'm not sure if these are literally aliases to each other or what.
Attachment #8716473 -
Flags: review?(gps) → review+
Assignee | ||
Comment 3•8 years ago
|
||
They treated identically as far as I can see. This is the only occurance: https://github.com/git/git/blob/master/remote.c#L381 skipDefaultUpdate seems more appropriate. 'git fetch' takes a specific remote, so having that fail when fetch is specifically requested is less surprising.
Keywords: checkin-needed
Comment 4•8 years ago
|
||
Note, that's partly why I said it would have been better to not add a remote...
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/hgcustom/version-control-tools/rev/cbca3728a843717cdfcf5d43ffd68b582421b2ce mozreview: Skip review remote in git updates. (bug 1246285) r=gps
Assignee | ||
Updated•8 years ago
|
Updated•8 years ago
|
Product: Developer Services → MozReview
You need to log in
before you can comment on or make changes to this bug.
Description
•