Fix a typo in DefineSelfHostedProperty

RESOLVED FIXED in Firefox 47

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8716480 [details] [diff] [review]
fix_DefineSelfHostedProperty_typo-v0.diff

Unless I'm missing something really obtuse, we appear to always set the setter to the getter. Which I guess means that self hosted code cannot have setters at the moment?
Attachment #8716480 - Flags: review?(till)
Comment on attachment 8716480 [details] [diff] [review]
fix_DefineSelfHostedProperty_typo-v0.diff

Review of attachment 8716480 [details] [diff] [review]:
-----------------------------------------------------------------

Speechless.
Attachment #8716480 - Flags: review?(till) → review+
(Assignee)

Comment 2

3 years ago
For the record, we counted and there are 17(!) places you'd need to update from g->s after doing a copy&paste. We could probably be organizing this code better.

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1cfe34ea394c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.