Closed Bug 1246302 Opened 8 years ago Closed 8 years ago

Random garbage parameters are not rejected in shavar response

Categories

(Toolkit :: Safe Browsing, defect, P3)

44 Branch
defect

Tracking

()

RESOLVED INVALID

People

(Reporter: mwobensmith, Unassigned)

References

Details

With the shavar response:

O}e3A{:C
u:foo.com


Results:
Response is parsed correctly.

Expected:
Reject response due to unknown leading garbage.
Assignee: francois → nobody
Blocks: 1149867
Priority: -- → P3
Marking invalid after chatting with François:

https://developers.google.com/safe-browsing/developers_guide_v2#HTTPResponseForData

"The client MUST ignore a line starting with a keyword that it doesn't understand."

Therefore, we correctly ignore the bad line, but we continue to honor the rest of the response.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.