Closed Bug 1246343 Opened 8 years ago Closed 7 years ago

context-menu icons not always present

Categories

(Add-on SDK Graveyard :: Documentation, enhancement)

Product:
Add-on SDK Graveyard
Component:
Documentation
Platform:
All
Linux
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: als, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20160105164030

Steps to reproduce:

I installed Nightly 46.0 to test my add-on.


Actual results:

The add-on adds a sub-menu to the context menu. In this sub-menu an icon that I set for one of the items was not present.  Also, all of the menus have no borders around them.


Expected results:

The xul.css says to respect the gtk-menu-images setting. The gtk3 default is for gtk-menu-images to be false.  This is unexpected for users who don't even use Gnome. Perhaps the documentation for the Add-On SDK could make it clear that the behaviour of the 'image' option in the context-menu API is dependent on a system setting.

It might be useful to have a page on migration to Gtk3 with useful settings that can be adjusted.
Severity: normal → enhancement
Component: General → Documentation
OS: Unspecified → Linux
Hardware: Unspecified → All
It appears that you have found a fix for the icon not showing on Linux platform, could you explain the fix?

This problem is related to issue 

https://bugzilla.mozilla.org/show_bug.cgi?id=1260398
In ~/.config/gtk-3.0/settings.ini have an entry

[Settings]
gtk-menu-images = true

Alternatively this could go into /etc/gtk-3.0/settings.ini
This appears to be a system setting and Linux users can't be expected to have this setting correctly set for the addon, therefore this remains a bug
Adding the setting did not solve the 'icon not showing' problem for me.
I can only report that it has an effect for Nightly (v46.0a1). v43.0.4 does not have the problem.
The icons I refer to are most of those down the left-hand side of the menus in the menu bar, also the context menu and its sub-menus. These are all instances of the Gtk3 menu widget.
Yes those are the same icons I am missing from my Addon. I have this problem in Firefox v.42 upgraded to v.45 still not working
https://bugzilla.mozilla.org/show_bug.cgi?id=1399562
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.