1246378 - Add-on DownThemAll! stop working due to array comprehensions and generator comprehensions removed in Firefox 46

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Mike Cheung]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160205004003

Steps to reproduce:

Install DownThemAll 2.18.1 (https://addons.mozilla.org/en-US/firefox/addon/downthemall/).


Actual results:

DownThemAll stop working due to array comprehensions and generator comprehensions removed.


Expected results:

Should work normally like FF45.0a2 and previous versions.

Comment 1

[Tezla]

I'm on Windows 10 64-Bit version 10.0.1586 had Firefox 46.0a2 (20160209004008) and my DownThemAll Extension is not working at all, right click menu is not working even the menubar (in Tools). I can open DownThemAll configuration only using the Add-ons Manager Page. I wonder what actually causing this.
List of All Extension:
- ADB Helper
- AdBlockPlus
- colorPicker
- Cookies Manager+
- DownThemAll
- Greasemonkey
- IP Address and Domain Information
- Mozilla Archive Format
- Valence
- Video Download Helper

ps. disabling all extension but DownThemAll did not resolve the issue. I also had most of my Mozilla Archive Format menus lost.

Comment 2

[Loic]

(In reply to Tezla from comment #1)
> I wonder what actually causing this.

The root cause is known, see the "Blocks" field of the bug report.

Comment 3

[Tezla]

(In reply to Loic from comment #2)
> (In reply to Tezla from comment #1)
> > I wonder what actually causing this.
> 
> The root cause is known, see the "Blocks" field of the bug report.

Well, i just realized i can't save images using right click -> Save Image As. Should i post another bug report? although initially i suspect it is related with this. I'm on 20160211004010 build anyway.

ps. at this point, i tried to completely uninstall firefox and remove user profiles with no luck. i wonder if its related to XUL (which is obviously i should post another bug report).

Comment 4

[Loic]

No it's the same root cause. Bug 1220564 has broken DTA: all entries of DTA in context menu are displayed and they don't work (no DTA window, no download).

Comment 5

[Ekanan Ketunuti]

fixed in https://bugs.downthemall.net/changeset/3829/trunk/modules

try out DTA Nightly https://code.downthemall.net/nightly/downthemall-nightly-trunk.xpi

Comment 6

[Tezla]

ok, sorry for a late reply.
the nightly fix worked like a charm. although i found out these button not working http://imgur.com/2ypHQe9 as i thought. clicking exit won't close the window, the minimize and maximize is not working either.

so, should i keep this nightly or wait for the main branch of downthemall? - well perhaps i will save it a while till official update issued.

on a side note, as per update on 2016-02-20 (20160220004011) the bug on invicible menus is still persist and 'save image as' still not working. so, basically the DTA extension is fixed, the source of the problem isn't.

thank you for a quick solution.

Comment 7

[Loic]

You should file a bug on DTA bug tracker. As this bug is resolved, I close it.

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

The bug was in the DTA addon and has been fixed by them (as mentioned in comment 5).