Console message: Chrome file doesn't exist: ... editorOverlay.css

RESOLVED FIXED in Thunderbird 47.0

Status

Thunderbird
Message Compose Window
--
minor
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Jorg K (GMT+1), Assigned: Paenglab)

Tracking

Trunk
Thunderbird 47.0
Unspecified
Windows

Thunderbird Tracking Flags

(thunderbird45 fixed, thunderbird46 fixed, thunderbird47 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
When opening a message composition window on Windows, I see:

Chrome file doesn't exist: C:\mozilla-source\comm-central\obj-i686-pc-mingw32\dist\bin\chrome\classic\skin\classic\messenger\messengercompose\editorOverlay.css

printed in the console.

Apparently this file only exists for Linux.

I haven't investigated where this is loaded. However, it would be reassuring not to see this message.

And while I'm complaining, here's another one:
Chrome file doesn't exist: C:\mozilla-source\comm-central\obj-i686-pc-mingw32\dist\bin\chrome\toolkit\skin\classic\global\icons\information-64.png
(Assignee)

Comment 1

2 years ago
Created attachment 8716636 [details] [diff] [review]
bug1246394.patch

information-64.png exists only on OS X. For Linux and Windows I use now information-32.png. Maybe we could overhaul this no connection page like the new in-content error pages and then use chrome://global/skin/icons/info.svg. What do you think, Aleth?

editorOverlay.css was used on Linux to add icons to menuitems. I remove this file completely and move the rules to messengercompose.css
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8716636 - Flags: review?(aleth)

Comment 2

2 years ago
Are both -32 and -64 versions needed in any platform? If not, you could rename it to information.png.
As adding preprocessing should be avoided if possible.

Comment 3

2 years ago
Comment on attachment 8716636 [details] [diff] [review]
bug1246394.patch

Review of attachment 8716636 [details] [diff] [review]:
-----------------------------------------------------------------

I was a bit confused at first because I couldn't find the Linux version of the icon, but it looks like Linux uses the Windows png:
https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/non-mac.jar.inc.mn#78

Good catch, and we should uplift this if it affects 45, which it probably does.

>Maybe we could overhaul this no connection page like the new in-content error pages

This makes sense but is a lot more work, probably better in a separate bug. Does 45 have the new error pages yet? Note the information pages here aren't really errors, but I know there are in-content information pages at least in Fx nightlies.
Attachment #8716636 - Flags: review?(aleth) → review+
(Assignee)

Comment 4

2 years ago
(In reply to :aceman from comment #2)
> Are both -32 and -64 versions needed in any platform? If not, you could
> rename it to information.png.
> As adding preprocessing should be avoided if possible.

The -64 version looks better but is only on OS X available. Because of this I'm planning an overhaul with info.svg. But this is monochrome and doesn't look good with the actual implementation.

This files already use preprocessing, so it makes it not worse.

(In reply to aleth [:aleth] from comment #3)
> >Maybe we could overhaul this no connection page like the new in-content error pages
> 
> This makes sense but is a lot more work, probably better in a separate bug.
> Does 45 have the new error pages yet? Note the information pages here aren't
> really errors, but I know there are in-content information pages at least in
> Fx nightlies.

It wasn't intended for this bug.
Keywords: checkin-needed

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 47.0
(Assignee)

Comment 6

2 years ago
Comment on attachment 8716636 [details] [diff] [review]
bug1246394.patch

[Approval Request Comment]
User impact if declined: missing icons on Linux and Windows
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8716636 - Flags: approval-comm-beta?
Attachment #8716636 - Flags: approval-comm-aurora?
(Reporter)

Updated

2 years ago
Attachment #8716636 - Flags: approval-comm-aurora? → approval-comm-aurora+
(Reporter)

Comment 7

2 years ago
Aurora (TB 46):
https://hg.mozilla.org/releases/comm-aurora/rev/7344e962567e
status-thunderbird45: --- → affected
status-thunderbird46: --- → fixed
status-thunderbird47: --- → fixed

Updated

2 years ago
status-thunderbird45: affected → fixed
You need to log in before you can comment on or make changes to this bug.