Closed Bug 1246394 Opened 4 years ago Closed 4 years ago

Console message: Chrome file doesn't exist: ... editorOverlay.css

Categories

(Thunderbird :: Message Compose Window, defect, minor)

Unspecified
Windows
defect
Not set
minor

Tracking

(thunderbird45 fixed, thunderbird46 fixed, thunderbird47 fixed)

RESOLVED FIXED
Thunderbird 47.0
Tracking Status
thunderbird45 --- fixed
thunderbird46 --- fixed
thunderbird47 --- fixed

People

(Reporter: jorgk-bmo, Assigned: Paenglab)

Details

Attachments

(1 file)

When opening a message composition window on Windows, I see:

Chrome file doesn't exist: C:\mozilla-source\comm-central\obj-i686-pc-mingw32\dist\bin\chrome\classic\skin\classic\messenger\messengercompose\editorOverlay.css

printed in the console.

Apparently this file only exists for Linux.

I haven't investigated where this is loaded. However, it would be reassuring not to see this message.

And while I'm complaining, here's another one:
Chrome file doesn't exist: C:\mozilla-source\comm-central\obj-i686-pc-mingw32\dist\bin\chrome\toolkit\skin\classic\global\icons\information-64.png
Attached patch bug1246394.patchSplinter Review
information-64.png exists only on OS X. For Linux and Windows I use now information-32.png. Maybe we could overhaul this no connection page like the new in-content error pages and then use chrome://global/skin/icons/info.svg. What do you think, Aleth?

editorOverlay.css was used on Linux to add icons to menuitems. I remove this file completely and move the rules to messengercompose.css
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8716636 - Flags: review?(aleth)
Are both -32 and -64 versions needed in any platform? If not, you could rename it to information.png.
As adding preprocessing should be avoided if possible.
Comment on attachment 8716636 [details] [diff] [review]
bug1246394.patch

Review of attachment 8716636 [details] [diff] [review]:
-----------------------------------------------------------------

I was a bit confused at first because I couldn't find the Linux version of the icon, but it looks like Linux uses the Windows png:
https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/non-mac.jar.inc.mn#78

Good catch, and we should uplift this if it affects 45, which it probably does.

>Maybe we could overhaul this no connection page like the new in-content error pages

This makes sense but is a lot more work, probably better in a separate bug. Does 45 have the new error pages yet? Note the information pages here aren't really errors, but I know there are in-content information pages at least in Fx nightlies.
Attachment #8716636 - Flags: review?(aleth) → review+
(In reply to :aceman from comment #2)
> Are both -32 and -64 versions needed in any platform? If not, you could
> rename it to information.png.
> As adding preprocessing should be avoided if possible.

The -64 version looks better but is only on OS X available. Because of this I'm planning an overhaul with info.svg. But this is monochrome and doesn't look good with the actual implementation.

This files already use preprocessing, so it makes it not worse.

(In reply to aleth [:aleth] from comment #3)
> >Maybe we could overhaul this no connection page like the new in-content error pages
> 
> This makes sense but is a lot more work, probably better in a separate bug.
> Does 45 have the new error pages yet? Note the information pages here aren't
> really errors, but I know there are in-content information pages at least in
> Fx nightlies.

It wasn't intended for this bug.
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 47.0
Comment on attachment 8716636 [details] [diff] [review]
bug1246394.patch

[Approval Request Comment]
User impact if declined: missing icons on Linux and Windows
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8716636 - Flags: approval-comm-beta?
Attachment #8716636 - Flags: approval-comm-aurora?
Attachment #8716636 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.