1246398 - link to compare talos results on treeherder job view brings up a view without a populated new revision

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

pick any talos job on inbound and click on it to see the details.  At the bottom of the talos data view, there is a link to  "Compare result against another revision":
https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=mozilla-inbound&newRevision=915eba505316

I click on this and the new revision ends up getting wiped out.  Once I enter it in, I can easily set the base revision.

I suspect this is a regression from the 'set base revision'

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1246398 > mozilla:master

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8720841 [details] [review]
[treeherder] wlach:1246398 > mozilla:master

This fixes the issue for me.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8720841 [details] [review]
[treeherder] wlach:1246398 > mozilla:master

r=me assuming this isn't try only!

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/4db12d33bb446fbf969441e85e403f980c1415e2
Bug 1246398 - Automatically offer to set base revision when preloading perf compare chooser