Status

Testing
Marionette
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ato, Assigned: ato)

Tracking

({ateam-marionette-server})

unspecified
mozilla47
ateam-marionette-server
Points:
---

Firefox Tracking Flags

(firefox46 fixed, firefox47 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

(Assignee)

Description

2 years ago
testing/marionette/driver.js has multiple issues.  We should do a Spring linting.
(Assignee)

Updated

2 years ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
Keywords: ateam-marionette-server
(Assignee)

Comment 1

2 years ago
Created attachment 8716654 [details]
MozReview Request: Bug 1246411 - Yield statements must be inside generator functions; r?automatedtester

Review commit: https://reviewboard.mozilla.org/r/33901/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33901/
Attachment #8716654 - Flags: review?(dburns)
(Assignee)

Comment 2

2 years ago
Created attachment 8716655 [details]
MozReview Request: Bug 1246411 - Access to properties is better written using dot notation; r?automatedtester

Review commit: https://reviewboard.mozilla.org/r/33903/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33903/
Attachment #8716655 - Flags: review?(dburns)
(Assignee)

Comment 3

2 years ago
Created attachment 8716656 [details]
MozReview Request: Bug 1246411 - Remove unreachable break statements; r?automatedtester

Review commit: https://reviewboard.mozilla.org/r/33905/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33905/
Attachment #8716656 - Flags: review?(dburns)
(Assignee)

Comment 4

2 years ago
Created attachment 8716657 [details]
MozReview Request: Bug 1246411 - Constructors must use new keyword; r?automatedtester

Review commit: https://reviewboard.mozilla.org/r/33907/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33907/
Attachment #8716657 - Flags: review?(dburns)
Attachment #8716654 - Flags: review?(dburns) → review+
Comment on attachment 8716654 [details]
MozReview Request: Bug 1246411 - Yield statements must be inside generator functions; r?automatedtester

https://reviewboard.mozilla.org/r/33901/#review30841
Comment on attachment 8716655 [details]
MozReview Request: Bug 1246411 - Access to properties is better written using dot notation; r?automatedtester

https://reviewboard.mozilla.org/r/33903/#review30843
Attachment #8716655 - Flags: review?(dburns) → review+
Comment on attachment 8716656 [details]
MozReview Request: Bug 1246411 - Remove unreachable break statements; r?automatedtester

https://reviewboard.mozilla.org/r/33905/#review30845
Attachment #8716656 - Flags: review?(dburns) → review+
Comment on attachment 8716657 [details]
MozReview Request: Bug 1246411 - Constructors must use new keyword; r?automatedtester

https://reviewboard.mozilla.org/r/33907/#review30847
Attachment #8716657 - Flags: review?(dburns) → review+

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c9539b0a2bf8
https://hg.mozilla.org/mozilla-central/rev/c1abf28f3b73
https://hg.mozilla.org/mozilla-central/rev/662bfc73887e
https://hg.mozilla.org/mozilla-central/rev/ae350a962463
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.