1246445 - Swift 2.2 changes

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Richard Newman [:rnewman]]

We'll need to merge this when Xcode 7.3 leaves beta. Not many changes, at least.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Pull req.

Note that this is still not enough, because we crash the compiler:

http://openradar.appspot.com/radar?id=6174752175554560

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8716690 [details] [review]
Pull req.

These are not issues anymore in the final Xcode 7.3 release.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/1666

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/1667

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8734706 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1667

Need a good amount of eyes on this patch.

The first two commits about compile errors. The rest is about warnings.

If I disable UITests then everything succeeds except testBookmark() and testTabManagerStoreChangesInDB(). We knew those were failing already, so that is nothing new.

UITests has to be disabled because of https://bugzilla.mozilla.org/show_bug.cgi?id=1259748

Comment 6

[Stephan Leroux [:sleroux]]

Comment on attachment 8734706 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1667

Looks good overall. Mostly nits and comments.

Comment 7

[Brian Nicholson (:bnicholson)]

Comment on attachment 8734706 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1667

LGTM!

Comment 9

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/1672

This is https://github.com/mozilla/firefox-ios/pull/1672 with all the nits addressed.