1246461 - Tracking Protection UI tour disagrees with Firefox UI about "disable protection for this (site/session)" wording

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: screenshot

I updated nightly on a laptop that I hadn't used for a few weeks, and got the tracking protection UI tour.

When I got to the page:
https://www.mozilla.org/en-US/firefox/47.0a1/tracking-protection/start/?step=3&newtab=true

I got a disagreement in wording.  The webpage pointed to a button saying it was labeled "Disable protection for this session", but the actual Firefox UI says "Disable protection for this site".

Comment 1

[Alex Gibson [:agibson]]

Thanks for the report - looks like the string changes depending on the context of the tour being opened in a private window or normal window. We can add some logic to accommodate.

Comment 2

[Alex Gibson [:agibson]]

Attachment: GitHub pull request

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/932db4607d66cce9e9cbd2dc3493a659a2f2d964
[fix bug 1246461] Update Tracking Protection tour string for step 3 in non-private windows

https://github.com/mozilla/bedrock/commit/da3a089d27513a7e8803ab5fbc8d98f68477a2e5
Merge pull request #3869 from alexgibson/bug-1246461-update-tp-tour-conditional-messaging

[fix bug 1246461] Update Tracking Protection tour string for step 3 in non-private windows