Closed Bug 1246477 Opened 4 years ago Closed 4 years ago
Caret is not updated if the input is being scrolled after long pressing
58 bytes, text/x-review-board-request
This is a regression by "Bug 1121468 - Go to NoActionState after receiving release on LongTapState." Steps to reproduce on Fennec: 1. Open Google search, and type some text to the search field. 2. Single tap elsewhere to make the keyboard go away. 3. Long tap to select a word on the search field without lifting the finger. This is necessary to reproduce this issue. 4. Observe the search field will be scrolled into the center of the screen. Expected result: The position of the carets is being updated to the correct place. Actual results: The position of the carets is at the wrong place.
This is a regression by "Bug 1121468 - Go to NoActionState after receiving release on LongTapState." When receiving a scroll event in LongTapState, i.e. apz starts, we should call OnScrollStart() and move to the ScrollState. Review commit: https://reviewboard.mozilla.org/r/33963/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33963/
Attachment #8716861 - Flags: review?(roc)
Comment on attachment 8716861 [details] MozReview Request: Bug 1246477 - Fix carets not updated by scroll events in LongTapState. r=roc https://reviewboard.mozilla.org/r/33963/#review30559
Attachment #8716861 - Flags: review?(roc) → review+
You need to log in before you can comment on or make changes to this bug.