1246516 - sidebar.css references non-existent chrome://global/skin/toolbar/tbgrip-texture.gif

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Philip Chee]

Attachment: tbgrip-texture.gif

While reviewing Bug 1242188 I noticed that the sidebar.css in classic has this:

> .sbtab-texture {
>   margin: 2px 0px;
>   background: url("chrome://global/skin/toolbar/tbgrip-texture.gif") repeat-y;
>   width: 12px;
>   height: 12px;
> }

But tbgrip-texture.gif doesn't exist. It did exist in the old XPFE SeaMonkey 1.x.

Your mission, Jim, should you decide to accept it is to add back tbgrip-texture.gif to /suite/themes/classic/communicator/sidebar/

And then edit sidebar.css changing:
  background: url("chrome://global/skin/toolbar/tbgrip-texture.gif") 
to:
  background: url("chrome://communicator/skin/sidebar/tbgrip-texture.gif")

The OSX version of sidebar.css also needs to be fixed:
/suite/themes/classic/mac/communicator/sidebar/sidebar.css

Comment 1

[Stefan [:stefanh]]

(In reply to Philip Chee from comment #0)
> The OSX version of sidebar.css also needs to be fixed:
> /suite/themes/classic/mac/communicator/sidebar/sidebar.css

I'm much happier without it, so please just remove the style rules in the OS X sidebar.css file.

Comment 2

[Shikhar Bhardwaj]

Attachment: Proposed patch for Bug 1246516

Comment 3

[Philip Chee]

Comment on attachment 8724433 [details] [diff] [review]
Proposed patch for Bug 1246516

Good starting patch!

There is one step missing:

You need to download attachment 8716801 [details]
And then  |hg add| it to:
suite/themes/classic/communicator/sidebar/
Since this is a binary file your patch must use the git format.

Also to get your patch reviewed, you need to set the review flag to [?] and most importantly fill in the "Requestee" textbox.

Comment 4

[Shikhar Bhardwaj]

Thanks for the comment!

I did |hg add| the file to the specified path and its also showing up in the patch. 

How do I generate patches in the git format? I have suitably modified ~/.hgrc to use git format for diffs.

Comment 5

[Philip Chee]

Ooops sorry it's a very small file. Will test this right now.

Comment 6

[Philip Chee]

Comment on attachment 8724433 [details] [diff] [review]
Proposed patch for Bug 1246516

O.K. I totally screwed up. tbgrip-texture.gif does already exist but under suite/themes/classic/communicator/toolbar/

New patch:
1. backout the tbgrip-texture.gif in sidebar. If you are using mercurial queues (mq) you can hg rm the file and then hg qrefresh.

2. In suite/themes/classic/communicator/sidebar/sidebar.css do:
>  .sbtab-texture {
>    margin: 2px 0px;
> -  background: url("chrome://global/skin/toolbar/tbgrip-texture.gif") repeat-y;
> +  background: url("chrome://communicator/skin/toolbar/tbgrip-texture.gif") repeat-y;

3. Your changes to the Mac version of sidebar.css remain valid.

Comment 7

[Shikhar Bhardwaj]

Attachment: Proposed patch #2 for Bug 1246516

Comment 8

[Philip Chee]

Comment on attachment 8724695 [details] [diff] [review]
Proposed patch #2 for Bug 1246516

works great!
r=me

Comment 9

[Philip Chee]

Adding the checkin-needed keyword. You should do this if you are not or cannot check this in yourself.

Comment 10

[Shikhar Bhardwaj]

(In reply to Philip Chee from comment #9)
> Adding the checkin-needed keyword. You should do this if you are not or
> cannot check this in yourself.

Thank you so much for guiding me through this.

Comment 11

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/f59c225426eb