1246522 - Rules Tab in Inspector is empty for all elements

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Off By None]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160206030207

Steps to reproduce:

Open WebIDE and connect to iOS safari (I was using an iPad running I think 9.1)
Open the dev tools and navigate to the inspector tab.
Select an element on the page in the inspector

This happened across all pages I tried in both current dev edition and current nightly.
Windows 7x64 and 8.1x64.  With and without e10s.


Actual results:

The Rules tab was empty for any element I selected on the page. I also got the below error in the browser console:

columnNumber:11
fileName:"resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/css-parsing-utils.js"
lineNumber:989
message:"empty input string"
stack:"parsePseudoClassesAndAttributes@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/css-parsing-utils.js:989:11
RuleEditor.prototype.populate/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/rules/views/rule-editor.js:298:30
RuleEditor.prototype.populate@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/rules/views/rule-editor.js:283:7
RuleEditor.prototype._create@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/rules/views/rule-editor.js:171:5
RuleEditor@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/rules/views/rule-editor.js:75:3
CssRuleView.prototype._createEditors@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/inspector/rules/rules.js:1162:23
CssRuleView.prototype._populate/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/cl"


Expected results:

The CSS rules for the element should have been shown in the rules tab

Comment 1

[Off By None]

Adding ttromey as I mentioned this in the DevTools mailing list before I had repro steps and he wanted to know if I ever got any.

Comment 2

[Tom Tromey :tromey]

I think gl wrote parsePseudoClassesAndAttributes, so moving the NI to him.

Offhand I would guess this is a problem on the server-side though.

Comment 3

[Tom Tromey :tromey]

More confirmation that this is a valence problem:

https://github.com/mozilla/valence/issues/206

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

What URLs were you testing?  I have seen this issue, but not for every page, so it would be great to check the same page you're trying as well.

Comment 5

[Off By None]

Sorry for not responding sooner, I have been busy the last few days.  I don't recall the URLs I was using and I don't have an iOS device on me at the moment.  I will try to get you some URLs by the end of the week.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Off By None from comment #5)
> Sorry for not responding sooner, I have been busy the last few days.  I
> don't recall the URLs I was using and I don't have an iOS device on me at
> the moment.  I will try to get you some URLs by the end of the week.

Okay, that would be a big help to confirm the issue.  Here is a test build of the add-on which I believe may fix this issue:

https://cloudup.com/cNdwTVbE4vj (choose the right XPI for your OS)

This is an unsigned add-on, so you would need to set xpinstall.signatures.required to false in about:config to allow installation.

Once you are done testing it, please remove it and re-install the production version from:

https://archive.mozilla.org/pub/labs/valence/

or from within WebIDE to ensure you receive future updates.

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Ah, I guess you said you no longer have a device...  In any case, URLs would still help as well. :)

Comment 8

[Off By None]

I have a device it just isn't on me at the moment.

Comment 9

[Off By None]

I can't repro anymore, looks like your update fixed it.

Thanks for the quick fix!

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Great, thanks for testing!

https://github.com/mozilla/valence/commit/e5ec89ad3e8eda253c798eb803b2bda4562f9dea