Closed Bug 1246561 Opened 5 years ago Closed 5 years ago

remove admin ui for mozreview settings

Categories

(MozReview Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glob, Assigned: glob)

References

Details

Attachments

(1 file)

bug 1245524 moved mozreview's settings to a json file, however the reviewboard admin ui still exists.

it should be removed and replaced with a reference to the file containing the settings, or updated to edit the json file.
Assignee: nobody → glob
MozReview's settings were moved to a JSON file, however the admin UI for the
settings remained.  As providing values for these settings in the admin UI does
nothing but expose those settings to all clients, this changes our UI to a
reference to the json file.

Review commit: https://reviewboard.mozilla.org/r/34473/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34473/
Attachment #8718232 - Flags: review?(dminor)
Comment on attachment 8718232 [details]
MozReview Request: mozreview: remove settings from admin UI (bug 1246561) r?dminor

https://reviewboard.mozilla.org/r/34473/#review31191

Thanks for fixingthis.

::: pylib/mozreview/mozreview/extension.py:336
(Diff revision 1)
>              return self.default_settings.get(key, default)

Please remove the use of default_settings here.
Attachment #8718232 - Flags: review?(dminor) → review+
https://hg.mozilla.org/hgcustom/version-control-tools/rev/0ba15a1bf167
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.