1246561 - remove admin ui for mozreview settings

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[:glob ✱]

bug 1245524 moved mozreview's settings to a json file, however the reviewboard admin ui still exists.

it should be removed and replaced with a reference to the file containing the settings, or updated to edit the json file.

Comment 1

[:glob ✱]

Attachment: MozReview Request: mozreview: remove settings from admin UI (bug 1246561) r?dminor

MozReview's settings were moved to a JSON file, however the admin UI for the
settings remained.  As providing values for these settings in the admin UI does
nothing but expose those settings to all clients, this changes our UI to a
reference to the json file.

Review commit: https://reviewboard.mozilla.org/r/34473/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34473/

Comment 2

[Dan Minor [:dminor]]

Comment on attachment 8718232 [details]
MozReview Request: mozreview: remove settings from admin UI (bug 1246561) r?dminor

https://reviewboard.mozilla.org/r/34473/#review31191

Thanks for fixingthis.

::: pylib/mozreview/mozreview/extension.py:336
(Diff revision 1)
>              return self.default_settings.get(key, default)

Please remove the use of default_settings here.

Comment 3

[:glob ✱]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/0ba15a1bf167