Closed Bug 1246584 Opened 4 years ago Closed 9 months ago

‘QGeoPositionInfo’ does not name a type

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED INACTIVE

People

(Reporter: cocof35serveur, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

log
32.50 KB, text/plain
Details
903 bytes, patch
Details | Diff | Splinter Review
Attached file log
User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20160202150527

Steps to reproduce:

Build firefox with this mozconfig:

. $topsrcdir/browser/config/mozconfig

mk_add_options MOZ_MAKE_FLAGS="-j4"
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/ff-build

ac_add_options --enable-release
ac_add_options --disable-tests
ac_add_options --with-system-zlib
ac_add_options --enable-default-toolkit=cairo-qt
ac_add_options --disable-updater
ac_add_options --with-pthreads
ac_add_options --enable-svg
ac_add_options --enable-canvas
ac_add_options --enable-libnotify




Actual results:

The build failed with the errors in the log


Expected results:

It should work as well as a gtk build
Blocks: qt, 528510
No longer blocks: qt
Product: Firefox → Core
Component: Untriaged → Build Config
OS: Unspecified → Linux
Hardware: Unspecified → x86_64
Attached patch fix.patch (obsolete) — Splinter Review
QGeoPositionInfo is in the namespace QtMobility.
Attachment #8719588 - Flags: review?(mshal)
Based on the patch, it looks like this needs review from a DOM peer rather than a build config peer.
Component: Build Config → DOM
Comment on attachment 8719588 [details] [diff] [review]
fix.patch

Feel free to redirect if I'm mistaken :)
Attachment #8719588 - Flags: review?(mshal) → review?(jst)
Comment on attachment 8719588 [details] [diff] [review]
fix.patch

Perhaps use the namespace explicitly where needed. Similar to https://bug815047.bmoattachments.org/attachment.cgi?id=685045

With that, r=smaug
Attachment #8719588 - Flags: review?(jst) → review+
Attached patch fix.patchSplinter Review
Attachment #8719588 - Attachment is obsolete: true
Component: DOM → DOM: Core & HTML
Status: UNCONFIRMED → RESOLVED
Closed: 9 months ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.