1246584 - ‘QGeoPositionInfo’ does not name a type

Status: RESOLVED INACTIVE

(Core :: DOM: Core & HTML, defect)

Description

[Godrod]

Attachment: log

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20160202150527

Steps to reproduce:

Build firefox with this mozconfig:

. $topsrcdir/browser/config/mozconfig

mk_add_options MOZ_MAKE_FLAGS="-j4"
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/ff-build

ac_add_options --enable-release
ac_add_options --disable-tests
ac_add_options --with-system-zlib
ac_add_options --enable-default-toolkit=cairo-qt
ac_add_options --disable-updater
ac_add_options --with-pthreads
ac_add_options --enable-svg
ac_add_options --enable-canvas
ac_add_options --enable-libnotify




Actual results:

The build failed with the errors in the log


Expected results:

It should work as well as a gtk build

Comment 1

[Godrod]

Attachment: fix.patch

QGeoPositionInfo is in the namespace QtMobility.

Comment 2

[Michael Shal [:mshal]]

Based on the patch, it looks like this needs review from a DOM peer rather than a build config peer.

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8719588 [details] [diff] [review]
fix.patch

Feel free to redirect if I'm mistaken :)

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8719588 [details] [diff] [review]
fix.patch

Perhaps use the namespace explicitly where needed. Similar to https://bug815047.bmoattachments.org/attachment.cgi?id=685045

With that, r=smaug

Comment 5

[Godrod]

Attachment: fix.patch