1246592 - L10n repacks/installers are busted on windows for locales containing a dash

Status: RESOLVED FIXED

Description

[Mark Banner (:standard8)]

Following the landing of bug 1239828, L10n repacks are busted on Windows - AFAICT for only locales that have a dash in the locale name:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-job_group_symbol=L10n&filter-job_group_symbol=Update-3&filter-job_group_symbol=Update-1&filter-job_group_symbol=Update-2&exclusion_profile=false&revision=76733110704b&selectedJob=3250897

https://treeherder.mozilla.org/logviewer.html#?job_id=3250897&repo=mozilla-central

IOError: [Errno 2] No such file or directory: '../../../dist/xpi-stage/locale-nb-NO/browser\\features/[e-mail]\\chrome\\content/shared/vendor/sdk-content/images/rtc/access-denied-copy-firefox.png'

Comment 1

[Axel Hecht [:Pike]]

Seems that weirdo heuristic to use shell or not when executing python process? I recall another bug recently where quoting has helped.

Comment 2

[Mark Banner (:standard8)]

I've tried reproducing this locally on my own system, but it runs successfully there.

I'm using:

./mach configure
<copy package/installer files into dist>
cd objdir/browser/locales
compare-locales -m /e/merged/ /e/fx-team/browser/locales/l10n.ini /e/fx-team/l10n-central/ en-GB
mozmake.exe langpack-en-GB LOCALE_MERGEDIR=/e/merged
mozmake.exe installers-en-GB LOCALE_MERGEDIR/e/merged

Comment 3

[Mark Banner (:standard8)]

Mike, can you help us here, not being able to reproduce is making it harder for me to guess where we might have got things wrong...

Comment 4

[Mike Hommey [:glandium]]

The best thing to do would be to separate out locales in a separate jar.mn and change the path that browser/locales recurses into. It's actually not a good thing that content and locales are mixed up, that means we're shipping content in langpacks.

Comment 5

[Mark Banner (:standard8)]

Attachment: Try and fix windows locale repack bustage by adjusting how locales are built for Loop.

Thank you for the suggestion Mike. This does the separation and I've tested it locally on Mac to check it works.

I couldn't reproduce the windows changes, so I'm not sure its worth testing there.

Comment 6

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/a6b8d2c921e3

Comment 7

[Mark Banner (:standard8)]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-job_group_symbol=L10n&filter-job_group_symbol=Update-3&filter-job_group_symbol=Update-1&filter-job_group_symbol=Update-2&exclusion_profile=false&revision=d1a54ae63da7 looks good now.

Thank you for the hint Mike.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8717336 [details] [diff] [review]
Try and fix windows locale repack bustage by adjusting how locales are built for Loop.

Approval Request Comment
[Feature/regressing bug #]: Bug 1239828
[User impact if declined]: Broken L10n repacks on Windows for locales with a dash.
[Describe test coverage new/current, TreeHerder]: Landed in m-c. Passes L10n builds
[Risks and why]: Low, simple build adjustment to bug 1239828
[String/UUID change made/needed]: None

Comment 9

[Mark Banner (:standard8)]

Attachment: Patch for beta

Approval Request Comment

Beta version, please see comment 8 for details.

Comment 10

[Mark Banner (:standard8)]

Attachment: Patch for beta

Approval Request Comment

Correct patch for beta.

Comment 11

[Liz Henry (:lizzard) (use needinfo)]

Comment on attachment 8717336 [details] [diff] [review]
Try and fix windows locale repack bustage by adjusting how locales are built for Loop.

Locale build fix for Hello, ok to uplift to aurora.

Comment 12

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/599d1590c990

Comment 13

[Sylvestre Ledru [:sylvestre]]

Comment on attachment 8717559 [details] [diff] [review]
Patch for beta

Should be in 45 beta 6.

Comment 14

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/mozilla-beta/rev/41eb59a46425

Comment 15

[Carsten Book [:Tomcat]]

backed this out in https://hg.mozilla.org/releases/mozilla-beta/rev/b454ec296bf6 on request from sylvestre for bustage like :

https://treeherder.mozilla.org/logviewer.html#?job_id=810287&repo=mozilla-beta

Comment 16

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/mozilla-beta/rev/e19adb94a81b

Comment 17

[Carsten Book [:Tomcat]]

backed out by request from sylvestre in https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=8bf2c5452d44