Closed
Bug 1246635
Opened 8 years ago
Closed 8 years ago
Enable dom/test/browser/autofocus tests in e10s
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: enndeakin, Assigned: enndeakin)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
5.32 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
2.56 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Attachment #8716931 -
Flags: review?(mrbkap)
Assignee | ||
Updated•8 years ago
|
Attachment #8716932 -
Flags: review?(mrbkap)
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d84120d7d9a4
Comment 4•8 years ago
|
||
Comment on attachment 8716931 [details] [diff] [review] browser_autofocus_background.js Review of attachment 8716931 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/tests/browser/browser_autofocus_background.js @@ +18,5 @@ > + > + // The focus event (from autofocus) has been sent, > + // let's test with executeSoon so we are sure the test is done > + // after the focus event is processed. > + yield new Promise(resolve => executeSoon(resolve)); Do you need the executeSoon? I think promises already return to the event loop. @@ +36,4 @@ > > + // Cleaning up. > + for (let i = 1; i < tabs.length; i++) { > + gBrowser.removeTab(tabs[i]); Do we need to wait for this to finish? I've been doing |yield BrowserTestUtils.removeTab(tabs[i]);| lately.
Attachment #8716931 -
Flags: review?(mrbkap) → review+
Updated•8 years ago
|
Attachment #8716932 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b9ef794250a3d97cde27ce9170223c5ff3ab511 Bug 1246635, enable browser_autofocus_background.js in e10s, r=mrbkap https://hg.mozilla.org/integration/mozilla-inbound/rev/6c4bf95cc639075c436e354397e4a2ea1c79ae82 Bug 1246635, enable browser_autofocus_preference.js in e10s, r=mrbkap
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1b9ef794250a https://hg.mozilla.org/mozilla-central/rev/6c4bf95cc639
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•