Closed Bug 1246635 Opened 8 years ago Closed 8 years ago

Enable dom/test/browser/autofocus tests in e10s

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
e10s + ---
firefox48 --- fixed

People

(Reporter: enndeakin, Assigned: enndeakin)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

      No description provided.
Attachment #8716931 - Flags: review?(mrbkap)
Attachment #8716932 - Flags: review?(mrbkap)
Comment on attachment 8716931 [details] [diff] [review]
browser_autofocus_background.js

Review of attachment 8716931 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tests/browser/browser_autofocus_background.js
@@ +18,5 @@
> +
> +  // The focus event (from autofocus) has been sent,
> +  // let's test with executeSoon so we are sure the test is done
> +  // after the focus event is processed.
> +  yield new Promise(resolve => executeSoon(resolve));

Do you need the executeSoon? I think promises already return to the event loop.

@@ +36,4 @@
>  
> +  // Cleaning up.
> +  for (let i = 1; i < tabs.length; i++) {
> +    gBrowser.removeTab(tabs[i]);

Do we need to wait for this to finish? I've been doing |yield BrowserTestUtils.removeTab(tabs[i]);| lately.
Attachment #8716931 - Flags: review?(mrbkap) → review+
Attachment #8716932 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/mozilla-central/rev/1b9ef794250a
https://hg.mozilla.org/mozilla-central/rev/6c4bf95cc639
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: