Closed Bug 1246650 Opened 4 years ago Closed 4 years ago

Update redux version to 3.0.4 or newer for devtools

Categories

(DevTools :: General, defect)

47 Branch
defect
Not set

Tracking

(firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(1 file, 1 obsolete file)

While working on Bug 1246570, I stumbled upon https://github.com/rackt/redux/issues/938 .

This issue was fixed in release 3.0.4 of redux. It would be nice to upgrade our Redux version to 3.0.4 or newer.

Also, we could keep a reference to the version of redux we have retrieved. Makes it easier to know if a bug fix is included in our version or not.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Attached patch bug1246650.v1.patch (obsolete) — Splinter Review
try : https://treeherder.mozilla.org/#/jobs?repo=try&revision=dae770c6fdf4

This commit upgrades our current version of redux to 3.3.0.

James : I picked 3.3.0 because it was the latest minor, and I didn't see any big issue on it (although it is pretty new ...). I am fine with anything > 3.0.4, so let me know if you'd prefer an older version!
Attachment #8716959 - Flags: review?(jlong)
Blocks: 1246570
Blocks: 1243131
Looks like James won't have much time to review this. 
Jordan, you added the previous version of redux, would it be OK for you to review this ? 

(commit is identical, just updated commit message)

try ongoing at : https://treeherder.mozilla.org/#/jobs?repo=try&revision=dae770c6fdf4
Attachment #8716959 - Attachment is obsolete: true
Attachment #8716959 - Flags: review?(jlong)
Attachment #8717060 - Flags: review?(jsantell)
Comment on attachment 8717060 [details] [diff] [review]
bug1246650.v1.patch

Review of attachment 8717060 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #8717060 - Flags: review?(jsantell) → review+
Thanks for the review! Try looks good.

Adding checkin-needed for attachment 8717060 [details] [diff] [review].
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1e3b60dd103a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.