Closed Bug 1246661 Opened 6 years ago Closed 6 years ago

Enable test_clipboard_events.html in e10s

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
e10s + ---
firefox48 --- fixed

People

(Reporter: enndeakin, Assigned: enndeakin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Attachment #8716976 - Flags: review?(bugs)
Attachment #8716976 - Flags: review?(bugs) → review?(mrbkap)
Comment on attachment 8716976 [details] [diff] [review]
test_clipboard_events

Review of attachment 8716976 [details] [diff] [review]:
-----------------------------------------------------------------

I have a couple of questions/comments, but r=me if you don't want to do them.

::: dom/tests/mochitest/general/test_clipboard_events.html
@@ +56,5 @@
> +  test_input_copy_button_dataTransfer,
> +  test_eventspref_disabled
> +  ];
> +
> +function doTests()

I don't know if it's worth it for you, but I've been using SpawnTask.js and spawn_task(generator_function) to avoid re-implementing this wheel. That would also mean that you could do:

function* doTests() {
  // init

  for (test of testFunctions) {
    yield test();
  }

  // cleanup.
}

which is cleaner.

@@ +525,5 @@
>  
>  function test_eventspref_disabled() {
>    // Disable clipboard events
> +  return new Promise(resolve => {
> +    SpecialPowers.pushPrefEnv({"set": [['dom.event.clipboardevents.enabled', false]]}, doPrefDisabledTest);

I wonder if we should add some promise-based pref functions to SpecialPowers.
Attachment #8716976 - Flags: review?(mrbkap) → review+
Are this and bug 1246662 ready to land?
https://hg.mozilla.org/mozilla-central/rev/2338e962df6d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.