Remove SEC_NORMAL from addon-sdk

RESOLVED FIXED in Firefox 49

Status

()

Core
DOM: Security
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ckerschb, Assigned: ckerschb)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Assignee: nobody → mozilla
Blocks: 1193558
Status: NEW → ASSIGNED
(Assignee)

Comment 1

2 years ago
Created attachment 8717077 [details] [diff] [review]
bug_1246725_rem_sec_normal_from_addon_sdk.patch
Attachment #8717077 - Flags: review?(jonas)
Attachment #8717077 - Flags: review?(jonas) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 2

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8bacae951c0c
Keywords: checkin-needed
backed this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=d00d189cd28b since test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=22016049&repo=mozilla-inbound when this changes landed
Flags: needinfo?(mozilla)
(Assignee)

Comment 4

2 years ago
(In reply to Carsten Book [:Tomcat] from comment #3)
> backed this out in
> https://treeherder.mozilla.org/#/jobs?repo=mozilla-
> inbound&revision=d00d189cd28b since test failures like
> https://treeherder.mozilla.org/logviewer.html#?job_id=22016049&repo=mozilla-
> inbound when this changes landed

Thanks Carsten, I'll have a look (not that important to land that conversion right now anyway). Potentially we should just wait will we have converted the URILoader to use asyncOpen2().
Flags: needinfo?(mozilla)
(Assignee)

Updated

2 years ago
Blocks: 1182535
No longer blocks: 1193558

Comment 5

2 years ago
Backout:
https://hg.mozilla.org/integration/b2g-inbound/rev/b069e5cf4bca
(Assignee)

Updated

2 years ago
Whiteboard: [domsecurity-active]

Comment 6

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/96d28a779269
Backed out for failing devtools test browser_dbg_addon-modules-unpacked.js

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/93c99ed44d94
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=96d28a77926955f1c986703223d49d7bfe4b3ed4
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=27505489&repo=mozilla-inbound
08:25:53     INFO -  53 INFO TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg_addon-modules-unpacked.js | Enough 'Debugger:EditorSourceShown' panel events have been fired. -
08:25:53     INFO -  54 INFO Source shown: file:///tmp/tmpaSVETE.mozrunner/extensions/browser_dbg_addon5@tests.mozilla.org/bootstrap.js
08:25:53     INFO -  55 INFO TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg_addon-modules-unpacked.js | The correct source has been shown. -
08:25:53     INFO -  56 INFO TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg_addon-modules-unpacked.js | Saw the right toolbox title. -
08:25:53     INFO -  57 INFO Getting sources.
08:25:53     INFO -  58 INFO TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg_addon-modules-unpacked.js | retrieved sources -
08:25:53     INFO -  59 INFO TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg_addon-modules-unpacked.js | Add-on code should be the first group - Got chrome://browser_dbg_addon5, expected browser_dbg_addon5@tests.mozilla.org
08:25:53     INFO -  Stack trace:
08:25:53     INFO -      chrome://mochikit/content/browser-test.js:test_is:967
08:25:53     INFO -      chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/browser_dbg_addon-modules-unpacked.js:test/<:22
08:25:53     INFO -      test@chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/browser_dbg_addon-modules-unpacked.js:11:3
08:25:53     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:810:9
08:25:53     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:711:7
08:25:53     INFO -      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:741:59
Flags: needinfo?(ckerschb)
(Assignee)

Comment 8

2 years ago
Thanks :aryx for backing this one out. I'll have a look what's going on.
Flags: needinfo?(ckerschb)
(Assignee)

Comment 9

2 years ago
Those devtool tests are failing:
* devtools/client/debugger/test/mochitest/browser_dbg_addon-modules-unpacked.js
* devtools/client/debugger/test/mochitest/browser_dbg_addon-modules.js
* devtools/client/debugger/test/mochitest/browser_dbg_addon-sources.js
* devtools/client/debugger/test/mochitest/browser_dbg_addon-workers-dbg-enabled.js
(Assignee)

Comment 10

2 years ago
Interestingly I get a different test result when using |ios.newChannelFromURI2| vs. NetUtil.newChannel() but using the same arguments within addon-sdk/source/lib/sdk/url.js. E.g. I would have to update browser_dbg_addon-modules-unpacked.js when using NetUtil.newChannel():

+++ b/devtools/client/debugger/test/mochitest/browser_dbg_addon-modules-unpacked.js
     // Check the inital list of sources is correct
     let groups = yield addonDebugger.getSourceGroups();
-    is(groups[0].name, "browser_dbg_addon5@tests.mozilla.org", "Add-on code should be the first group");
+    is(groups[0].name, "chrome://browser_dbg_addon5", "Add-on code should be the first group");
     is(groups[1].name, "chrome://global", "XUL code should be the second group");
-    is(groups.length, 2, "Should be only two groups.");
+    is(groups.length, 4, "Should be only four groups.");

I suppose those tests are just flaky, let's see if TRY would accept just replacing SEC_NORMAL with SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL.
(Assignee)

Comment 11

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed75d318b7f3
(Assignee)

Comment 12

2 years ago
(In reply to Christoph Kerschbaumer [:ckerschb] from comment #11)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed75d318b7f3

Looking at (dt9) - all the failing tests from Comment 9 are passing.

Comment 13

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ece69108baef

Comment 14

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ece69108baef
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.