Status
()
People
(Reporter: billm, Assigned: Andy McKay)
Tracking
Firefox Tracking Flags
(firefox47 fixed)
Details
(Whiteboard: [schema] triaged)
MozReview Requests
()
Submitter | Diff | Changes | Open Issues | Last Updated |
---|---|---|---|---|
Loading... | ||||
Error loading review requests: |
Attachments
(2 attachments)
This depends on bug 1243602 because of this test: https://dxr.mozilla.org/mozilla-central/source/toolkit/components/extensions/test/mochitest/test_ext_alarms.html#20
(Reporter) | ||
Comment 1•2 years ago
|
||
Created attachment 8720441 [details] [diff] [review] patch
Attachment #8720441 -
Flags: review?(kmaglione+bmo)
Comment on attachment 8720441 [details] [diff] [review] patch Review of attachment 8720441 [details] [diff] [review]: ----------------------------------------------------------------- The API methods also need to be updated to remove the manual optional arg handling and promise wrapping. ::: toolkit/components/extensions/schemas/alarms.json @@ +48,5 @@ > + }, > + { > + "name": "get", > + "type": "function", > + "description": "Retrieves details about the specified alarm.", "async": "callback", @@ +68,5 @@ > + }, > + { > + "name": "getAll", > + "type": "function", > + "description": "Gets an array of all the alarms.", "async": "callback", @@ +82,5 @@ > + }, > + { > + "name": "clear", > + "type": "function", > + "description": "Clears the alarm with the given name.", "async": "callback", @@ +102,5 @@ > + }, > + { > + "name": "clearAll", > + "type": "function", > + "description": "Clears all alarms.", "aysnc": "callback", @@ +121,5 @@ > + "type": "function", > + "description": "Fired when an alarm has expired. Useful for transient background pages.", > + "parameters": [ > + { > + "name": "name", Not a great parameter name, though I suppose it doesn't really matter.
Attachment #8720441 -
Flags: review?(kmaglione+bmo)
Updated•2 years ago
|
Flags: blocking-webextensions+
Priority: -- → P3
Whiteboard: [schema] triaged
(Assignee) | ||
Updated•2 years ago
|
Assignee: wmccloskey → amckay
(Assignee) | ||
Comment 3•2 years ago
|
||
Created attachment 8725967 [details] MozReview Request: bug 1246732 add in alarms schema r?kmag Review commit: https://reviewboard.mozilla.org/r/37719/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/37719/
Attachment #8725967 -
Flags: review?(kmaglione+bmo)
Comment on attachment 8725967 [details] MozReview Request: bug 1246732 add in alarms schema r?kmag https://reviewboard.mozilla.org/r/37719/#review34293 Thanks!
Attachment #8725967 -
Flags: review?(kmaglione+bmo) → review+
(Assignee) | ||
Updated•2 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/101e093a539c
Keywords: checkin-needed
Comment 6•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/101e093a539c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•