Status

defect
P3
normal
RESOLVED FIXED
3 years ago
11 months ago

People

(Reporter: billm, Assigned: andy+bugzilla)

Tracking

unspecified
mozilla47
Dependency tree / graph
Bug Flags:
blocking-webextensions +

Firefox Tracking Flags

(firefox47 fixed)

Details

(Whiteboard: [schema] triaged)

Attachments

(2 attachments)

Posted patch patchSplinter Review
Attachment #8720441 - Flags: review?(kmaglione+bmo)
Comment on attachment 8720441 [details] [diff] [review]
patch

Review of attachment 8720441 [details] [diff] [review]:
-----------------------------------------------------------------

The API methods also need to be updated to remove the manual optional arg handling and promise wrapping.

::: toolkit/components/extensions/schemas/alarms.json
@@ +48,5 @@
> +      },
> +      {
> +        "name": "get",
> +        "type": "function",
> +        "description": "Retrieves details about the specified alarm.",

"async": "callback",

@@ +68,5 @@
> +      },
> +      {
> +        "name": "getAll",
> +        "type": "function",
> +        "description": "Gets an array of all the alarms.",

"async": "callback",

@@ +82,5 @@
> +      },
> +      {
> +        "name": "clear",
> +        "type": "function",
> +        "description": "Clears the alarm with the given name.",

"async": "callback",

@@ +102,5 @@
> +      },
> +      {
> +        "name": "clearAll",
> +        "type": "function",
> +        "description": "Clears all alarms.",

"aysnc": "callback",

@@ +121,5 @@
> +        "type": "function",
> +        "description": "Fired when an alarm has expired. Useful for transient background pages.",
> +        "parameters": [
> +          {
> +            "name": "name",

Not a great parameter name, though I suppose it doesn't really matter.
Attachment #8720441 - Flags: review?(kmaglione+bmo)

Updated

3 years ago
Flags: blocking-webextensions+
Priority: -- → P3
Whiteboard: [schema] triaged
Assignee

Updated

3 years ago
Blocks: 1252297
Assignee

Updated

3 years ago
Assignee: wmccloskey → amckay
Comment on attachment 8725967 [details]
MozReview Request: bug 1246732 add in alarms schema r?kmag

https://reviewboard.mozilla.org/r/37719/#review34293

Thanks!
Attachment #8725967 - Flags: review?(kmaglione+bmo) → review+
Assignee

Updated

3 years ago
Keywords: checkin-needed

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/101e093a539c
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47

Updated

11 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.