1246732 - Add schema alarms.json

Status: RESOLVED FIXED

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

This depends on bug 1243602 because of this test:
https://dxr.mozilla.org/mozilla-central/source/toolkit/components/extensions/test/mochitest/test_ext_alarms.html#20

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Created attachment 8720441 [details] [diff] [review]
patch

Comment 2

[Kris Maglione [:kmag] (long backlog; ping on IRC if you're blocked)]

Comment on attachment 8720441 [details] [diff] [review]
patch

Review of attachment 8720441 [details] [diff] [review]:
-----------------------------------------------------------------

The API methods also need to be updated to remove the manual optional arg handling and promise wrapping.

::: toolkit/components/extensions/schemas/alarms.json
@@ +48,5 @@
> +      },
> +      {
> +        "name": "get",
> +        "type": "function",
> +        "description": "Retrieves details about the specified alarm.",

"async": "callback",

@@ +68,5 @@
> +      },
> +      {
> +        "name": "getAll",
> +        "type": "function",
> +        "description": "Gets an array of all the alarms.",

"async": "callback",

@@ +82,5 @@
> +      },
> +      {
> +        "name": "clear",
> +        "type": "function",
> +        "description": "Clears the alarm with the given name.",

"async": "callback",

@@ +102,5 @@
> +      },
> +      {
> +        "name": "clearAll",
> +        "type": "function",
> +        "description": "Clears all alarms.",

"aysnc": "callback",

@@ +121,5 @@
> +        "type": "function",
> +        "description": "Fired when an alarm has expired. Useful for transient background pages.",
> +        "parameters": [
> +          {
> +            "name": "name",

Not a great parameter name, though I suppose it doesn't really matter.

Comment 3

[Andy McKay]

Created attachment 8725967 [details]
MozReview Request: bug 1246732 add in alarms schema r?kmag

Review commit: https://reviewboard.mozilla.org/r/37719/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37719/

Comment 4

[Kris Maglione [:kmag] (long backlog; ping on IRC if you're blocked)]

Comment on attachment 8725967 [details]
MozReview Request: bug 1246732 add in alarms schema r?kmag

https://reviewboard.mozilla.org/r/37719/#review34293

Thanks!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/101e093a539c

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/101e093a539c