Closed Bug 1246872 Opened 8 years ago Closed 8 years ago

Fix bundle name for OS X artifact builds from trees other than inbound or fx-team

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

Details

Attachments

(1 file)

Right now the source bundle dir is hardcoded to 'Nightly.app', but this doesn't match artifacts coming from central: they will be 'FirefoxNightly.app'.
Attachment #8717328 - Flags: review?(nalexander) → review+
Comment on attachment 8717328 [details]
MozReview Request: Bug 1246872 - Find the source bundle directory by pattern matching for OS X artifact builds. r=nalexander

https://reviewboard.mozilla.org/r/34139/#review30869

I'm fine with this.  I see from the ticket that the idea is to allow taking a `NightlyDebug.app` and similar?  Can you update the commit message to say that?

::: python/mozbuild/mozbuild/artifacts.py:265
(Diff revision 1)
> -            # TODO: Extract the bundle name from the archive (it may differ
> +            bundle_dirs = glob.glob(mozpath.join(tempdir, '*.app'))

Prefer to use the `FileFinder` APIs.
https://reviewboard.mozilla.org/r/34139/#review30869

> Prefer to use the `FileFinder` APIs.

I'm finding that the '*.app' pattern matches every file in the bundle when I use it as a mozpath pattern.
https://hg.mozilla.org/mozilla-central/rev/af565d48561c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: