1246886 - [Static Analysis][Uninitialized scalar field] In function InterruptFrame(InterruptFrame&& aOther)

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that member mMoved is not initialized in the move constructor. The path that the move constructor gets called is:

>>        if (!mThat.mCxxStackFrames.append(InterruptFrame(direction, msg)))
>>            MOZ_CRASH();

The aOther object will have mMoved initialized by constructor InterruptFrame(Direction direction, const Message* msg) but when calling the move constructor the value of mMoved will not be passed to the new object.

Comment 1

[Andi [:andi]]

Attachment: MozReview Request: Bug 1246886 - initialize mMoved in move contructor. r?billm

Review commit: https://reviewboard.mozilla.org/r/34143/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34143/

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8717355 [details]
MozReview Request: Bug 1246886 - initialize mMoved in move contructor. r?billm

https://reviewboard.mozilla.org/r/34143/#review30859

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b1347b5e201e

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b1347b5e201e