Closed
Bug 1246927
Opened 8 years ago
Closed 8 years ago
Fix OOM handling in usages of GlobalObject::maybeGetIntrinsicValue
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: till, Assigned: till)
Details
Attachments
(1 file)
|
3.20 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
GlobalObject::maybeGetIntrinsicValue currently conflates OOM errors and benign "value not found on intrinsics holder" results in invalid ways. Patch coming up
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8717416 -
Flags: review?(arai.unmht)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8717416 [details] [diff] [review] Fix OOM handling in usages of GlobalObject::maybeGetIntrinsicValue Review of attachment 8717416 [details] [diff] [review]: ----------------------------------------------------------------- Nice :D ::: js/src/vm/GlobalObject.h @@ +600,5 @@ > } > > static bool > maybeGetIntrinsicValue(JSContext* cx, Handle<GlobalObject*> global, Handle<PropertyName*> name, > + MutableHandleValue vp, bool* found) s/found/exists/ maybe?
Attachment #8717416 -
Flags: review?(arai.unmht) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/902f29ef36e6e1aaf8a86952f66265617eca56f7 Bug 1246927 - Fix OOM handling in usages of GlobalObject::maybeGetIntrinsicValue. r=arai
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/902f29ef36e6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•