1247008 - New tools datepicker does not include times, pops under

Status: RESOLVED FIXED

(Taskcluster :: UI, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Screenshot from 2016-02-09 14-13-20.png

The new datepicker has a weird format:

  Saturday, February 3017

which is easy enough to fix by specifying a different dateFormat.  However, for secrets at least the expiration *time* is going to be important  (as secrets may have lifetimes rendered in hours), and this tool appears to support dates only.

Also, it's popping under the text boxes below it on the screen; see attachment.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Jonas, advice here?

Comment 2

[Jonas Finnemann Jensen (:jonasfj)]

Find a new better date-picker... Or let's play with some CSS tricks.. I'm sure z-index: 999 + some position: relative thrown around will do the trick.

The react-widget library we used before got really complicated to use.

Comment 3

[Jonas Finnemann Jensen (:jonasfj)]

datepicker__tether-element:
  z-index: 10

Does the trick... I'll try and upgrade the date-picker to a new version, maybe it got fixed.

Comment 4

[Jonas Finnemann Jensen (:jonasfj)]

https://github.com/taskcluster/taskcluster-tools/pull/55

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/taskcluster/taskcluster-tools

https://github.com/taskcluster/taskcluster-tools/commit/9862bf1f6fa828483e4098666f9690a66cc9e744
Fix bug 1247008

https://github.com/taskcluster/taskcluster-tools/commit/6c12f0cdebad4bd26f67b65e9b2ad2b64ccae633
Merge pull request #55 from taskcluster/bug-1247008

Bug 1247008

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

That fixes the popunder, but not the more important issue that it only picks dates, not times.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster-tools/pull/63

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/taskcluster/taskcluster-tools

https://github.com/taskcluster/taskcluster-tools/commit/cdf9c40809b1895699b1ce52edbd9e187a3d3143
Bug 1247008: replace lame DatePicker with TimeInput

https://github.com/taskcluster/taskcluster-tools/commit/948e474354c7b066a18591c8ba164f893c17e744
Merge pull request #63 from djmitche/fix-datetime

Bug 1247008: replace lame DatePicker with TimeInput