1247012 - MozReview-Commit-ID may not have empty line after summary line

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Gregory Szorc [:gps]]

A few times I've seen commit messages of the form:

summary
MozReview-Commit-ID: *


There should be a blank line between the summary line and MozReview-Commit-ID. This happens with the Mercurial extension.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: reviewboard: add test demonstrating no empty line after summary (bug 1247012); r?dminor

Review commit: https://reviewboard.mozilla.org/r/34219/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34219/

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: reviewboard: be more strict about detecting metadata lines (bug 1247012); r?dminor

Review commit: https://reviewboard.mozilla.org/r/34221/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34221/

Comment 3

[Dan Minor [:dminor]]

Comment on attachment 8717569 [details]
MozReview Request: reviewboard: add test demonstrating no empty line after summary (bug 1247012); r?dminor

https://reviewboard.mozilla.org/r/34219/#review30917

::: hgext/reviewboard/tests/test-commitid.t:119
(Diff revision 1)
> +"topic: foo" commit messages result in empty line

Please add a note indicating that the test currently shows incorrect behaviour.

Comment 4

[Dan Minor [:dminor]]

Comment on attachment 8717570 [details]
MozReview Request: reviewboard: be more strict about detecting metadata lines (bug 1247012); r?dminor

https://reviewboard.mozilla.org/r/34221/#review30919

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/48985bc8870a6fa2b6b82577519766eb9089ed9b
reviewboard: add test demonstrating no empty line after summary (bug 1247012); r=dminor

https://hg.mozilla.org/hgcustom/version-control-tools/rev/71cdc554e08cd2c765081479a13d34504b15ca93
reviewboard: be more strict about detecting metadata lines (bug 1247012); r=dminor