Closed Bug 1247012 Opened 5 years ago Closed 5 years ago

MozReview-Commit-ID may not have empty line after summary line

Categories

(MozReview Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(2 files)

A few times I've seen commit messages of the form:

summary
MozReview-Commit-ID: *


There should be a blank line between the summary line and MozReview-Commit-ID. This happens with the Mercurial extension.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Blocks: 1247029
Comment on attachment 8717569 [details]
MozReview Request: reviewboard: add test demonstrating no empty line after summary (bug 1247012); r?dminor

https://reviewboard.mozilla.org/r/34219/#review30917

::: hgext/reviewboard/tests/test-commitid.t:119
(Diff revision 1)
> +"topic: foo" commit messages result in empty line

Please add a note indicating that the test currently shows incorrect behaviour.
Attachment #8717569 - Flags: review?(dminor) → review+
Comment on attachment 8717570 [details]
MozReview Request: reviewboard: be more strict about detecting metadata lines (bug 1247012); r?dminor

https://reviewboard.mozilla.org/r/34221/#review30919
Attachment #8717570 - Flags: review?(dminor) → review+
https://hg.mozilla.org/hgcustom/version-control-tools/rev/48985bc8870a6fa2b6b82577519766eb9089ed9b
reviewboard: add test demonstrating no empty line after summary (bug 1247012); r=dminor

https://hg.mozilla.org/hgcustom/version-control-tools/rev/71cdc554e08cd2c765081479a13d34504b15ca93
reviewboard: be more strict about detecting metadata lines (bug 1247012); r=dminor
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.