1247038 - "ValueError: too many values to unpack" doing incremental build on Windows

Status: RESOLVED DUPLICATE of bug 1245328

(Testing :: Mozbase, defect)

Description

[George Wright (:gw280) (needinfo me!)]

I modified CompositorD3D11.cpp, and when I ran mach build I got the following:

 0:45.42 CompositorD3D11.obj
 0:45.64 Traceback (most recent call last):
 0:45.66   File "c:\mozilla-build\python\Lib\runpy.py", line 162, in _run_module_as_main
 0:45.68     "__main__", fname, loader, pkg_name)
 0:45.70   File "c:\mozilla-build\python\Lib\runpy.py", line 72, in _run_code
 0:45.71     exec code in run_globals
 0:45.72   File "c:\dev\gecko-dev\python\mozbuild\mozbuild\action\cl.py", line 124, in <module>
 0:45.72     sys.exit(main(sys.argv[1:]))
 0:45.72   File "c:\dev\gecko-dev\python\mozbuild\mozbuild\action\cl.py", line 121, in main
 0:45.72     return InvokeClWithDependencyGeneration(args)
 0:45.72   File "c:\dev\gecko-dev\python\mozbuild\mozbuild\action\cl.py", line 96, in InvokeClWithDepe
ndencyGeneration
 0:45.72     p.run()
 0:45.72   File "c:\dev\gecko-dev\testing\mozbase\mozprocess\mozprocess\processhandler.py", line 727,
in run
 0:45.72     self.proc = self.Process([self.cmd] + self.args, **args)
 0:45.72   File "c:\dev\gecko-dev\testing\mozbase\mozprocess\mozprocess\processhandler.py", line 114,
in __init__
 0:45.72     universal_newlines, startupinfo, creationflags)
 0:45.72   File "c:\mozilla-build\python\Lib\subprocess.py", line 710, in __init__
 0:45.72     errread, errwrite)
 0:45.72   File "c:\dev\gecko-dev\testing\mozbase\mozprocess\mozprocess\processhandler.py", line 212,
in _execute_child
 0:45.72     errread, errwrite) = args_tuple
 0:45.72 ValueError: too many values to unpack
 0:45.72
 0:45.72 In the directory  /c/dev/gecko-dev/obj-i686-pc-mingw32/gfx/layers
 0:45.72 The following command failed to execute properly:
 0:45.72 c:/dev/gecko-dev/obj-i686-pc-mingw32/_virtualenv/Scripts/python.exe -m mozbuild.action.cl cl
-FoCompositorD3D11.obj -c -I../../dist/stl_wrappers -DGOOGLE_PROTOBUF_NO_RTTI -DWIN32_LEAN_AND_MEAN -D
_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD
 -DU_STATIC_IMPLEMENTATION -DUNICODE -DNOMINMAX -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC -DMOZ_ENABLE_
D3D10_LAYER -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DAB_CD=en-US -DNO_NSPR_10
_SUPPORT -Ic:/dev/gecko-dev/gfx/layers -I. -Ic:/dev/gecko-dev/obj-i686-pc-mingw32/ipc/ipdl/_ipdlheader
s -Ic:/dev/gecko-dev/ipc/chromium/src -Ic:/dev/gecko-dev/ipc/glue -Ic:/dev/gecko-dev/docshell/base -Ic
:/dev/gecko-dev/layout/base -I../../dist/include -Ic:/dev/gecko-dev/obj-i686-pc-mingw32/dist/include/n
spr -Ic:/dev/gecko-dev/obj-i686-pc-mingw32/dist/include/nss -MD -FI ../../dist/include/mozilla-config.
h -DMOZILLA_CLIENT -TP -nologo -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:IA32 -FS -wd4251 -wd4244 -wd4267 -wd4
345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR- -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -O1 -Oi -Oy-
-I/frameworks/base/include/media/stagefright -I/frameworks/base/include/media/stagefright/openmax -I/f
rameworks/av/include/media/stagefright -I/frameworks/native/include/media/openmax -Ic:/dev/gecko-dev/o
bj-i686-pc-mingw32/dist/include/cairo -Fdgenerated.pdb c:/dev/gecko-dev/gfx/layers/d3d11/CompositorD3D
11.cpp

Comment 1

[Gregory Szorc [:gps]]

Stack points to a bug in mozprocess. mozprocess.processhandler._execute_child():212.

Comment 2

[George Wright (:gw280) (needinfo me!)]

So interestingly, line 212 of processhandler.py is in an if block conditional on python < 2.7.6. The python installed on my system is 2.7.10.