Closed Bug 1247054 Opened 4 years ago Closed 4 years ago

Error running `mach reftest` on Android | ImportError: No module named devicemanager

Categories

(Testing :: Reftest, defect)

Unspecified
Android
defect
Not set

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file)

I'm not sure if this is a regression from my structured logging patch, or if it is a longer standing issue. After fixing this issue, there is another failure in mach_commands.py, this second one is definitely a regression from the structured logging patch.
There is an ImportError on Android, as well as a log related
regression from the structured log patch once that is fixed.

Review commit: https://reviewboard.mozilla.org/r/34391/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34391/
Attachment #8718090 - Flags: review?(gbrown)
Here's some try runs:
https://treeherder.mozilla.org/#/jobs?repo=try&author=ahalberstadt@mozilla.com&fromchange=30e3361edc82&tochange=97fc0e96d1f4

For some reason android crashtest/jsreftest aren't getting run, but it's probably ok. This is the type of patch that likely breaks everything or nothing.
Comment on attachment 8718090 [details]
MozReview Request: Bug 1247054 - Fix |mach reftest| on Android, r?gbrown

https://reviewboard.mozilla.org/r/34391/#review31111

Looks good. I verified both 'mach reftest' and 'mach robocop' against an emulator -- all's well.
Attachment #8718090 - Flags: review?(gbrown) → review+
https://hg.mozilla.org/mozilla-central/rev/0ca917b25c1b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Depends on: 1247730
You need to log in before you can comment on or make changes to this bug.