1247073 - DesktopInstance should not enable extension logging by default

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Right now the Marionette driver DesktopInstance has extension logging enabled. We should turn this off given that it is not used by default and only clutters the logging output.

https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver/marionette_driver/geckoinstance.py#211

I think it should be enough to simply remove this line.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: No extension logging by default v1

No logging by default! It will make our logs way smaller and better to read.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8717814 [details] [diff] [review]
No extension logging by default v1

Review of attachment 8717814 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Please use MozReview next time.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

mozreview is not yet supported with git+cinnabar. So I cannot use it right now.

Comment 5

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #4)
> mozreview is not yet supported with git+cinnabar. So I cannot use it right
> now.

It is supported: http://mozilla-version-control-tools.readthedocs.org/en/latest/mozreview/install-git.html

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Oh, the blocking bug 1244835 got fixed. So indeed, I will use mozreview from now on.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da0b85937f77

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/da0b85937f77