1247117 - De-namespace much of IndexedDB

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Move all of the DOM objects to mozilla::dom, keep implementation details that might conflict with other modules in mozilla::dom::indexedDB.

Comment 1

[Andrea Marchesini [:baku]]

Comment on attachment 8717690 [details] [diff] [review]
Patch

Review of attachment 8717690 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsGlobalWindow.cpp
@@ +183,5 @@
>  #include "prenv.h"
>  #include "prprf.h"
>  
>  #include "mozilla/dom/MessageChannel.h"
> +#include "mozilla/dom/IDBFactory.h"

alphabetic order here.

::: dom/bindings/Bindings.conf
@@ +633,5 @@
>      'wrapperCache': False,
>  },
>  
>  'IDBLocaleAwareKeyRange': {
> +    'headerFile': 'IDBKeyRange.h',

why is this not exposed under mozilla/dom ?

::: dom/datastore/DataStoreDB.cpp
@@ +10,5 @@
>  #include "jsapi.h"
>  #include "mozilla/dom/IDBDatabaseBinding.h"
>  #include "mozilla/dom/IDBFactoryBinding.h"
>  #include "mozilla/dom/IDBObjectStoreBinding.h"
> +#include "mozilla/dom/IDBDatabase.h"

alphabetic order for all of these.

::: dom/datastore/DataStoreRevision.cpp
@@ +10,5 @@
>  #include "DataStoreService.h"
>  #include "mozilla/dom/DataStoreBinding.h"
>  #include "mozilla/dom/ToJSValue.h"
> +#include "mozilla/dom/IDBObjectStore.h"
> +#include "mozilla/dom/IDBRequest.h"

ditto.

::: dom/indexedDB/IDBObjectStore.h
@@ +53,2 @@
>    // For AddOrPut() and DeleteInternal().
>    friend class IDBCursor; 

can you remove this extra space here?

::: dom/workers/WorkerScope.cpp
@@ +20,5 @@
>  #include "mozilla/dom/SharedWorkerGlobalScopeBinding.h"
>  #include "mozilla/dom/WorkerDebuggerGlobalScopeBinding.h"
>  #include "mozilla/dom/WorkerGlobalScopeBinding.h"
>  #include "mozilla/dom/cache/CacheStorage.h"
> +#include "mozilla/dom/IDBFactory.h"

alphabetic order.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/320bbd5c0862

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Andrea Marchesini (:baku) from comment #1)
> ::: dom/bindings/Bindings.conf
> @@ +633,5 @@
> >      'wrapperCache': False,
> >  },
> >  
> >  'IDBLocaleAwareKeyRange': {
> > +    'headerFile': 'IDBKeyRange.h',
> 
> why is this not exposed under mozilla/dom ?

It is, this annotation exists to tell the binding generator that there's no IDBLocaleAwareKeyRange.h.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/320bbd5c0862