Closed Bug 1247126 Opened 6 years ago Closed 6 years ago

[jsdbg2] tenuring log is not used, and should be deleted (drainTenurePromotionsLog, etc)

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47

People

(Reporter: jimb, Assigned: jimb)

References

Details

Attachments

(1 file, 1 obsolete file)

The Debugger API's tenure promotions log should be deleted.

The tenure promotions log is not used by the developer tools, and we have no immediate plans to use it. It's also difficult to make the log work consistently if we permit minor garbage collections to be triggered by the act of recording allocation metadata (call stacks) itself: the object gets tenured before we're able to attach a stack to it.
Long Live The Tenure Promotions Log!
Attachment #8717708 - Flags: review?(nfitzgerald)
Comment on attachment 8717708 [details] [diff] [review]
Remove Debugger's tenure promotion log.

Review of attachment 8717708 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think we strictly need JS::Zone::hasDebuggers nor js::Debugger::debuggeeZones anymore either (I added them for the tenure promotions log), but it seems like we might want to keep them around anyways for the brave new zone-focused, cx-free world.
Attachment #8717708 - Flags: review?(nfitzgerald) → review+
Comment on attachment 8717708 [details] [diff] [review]
Remove Debugger's tenure promotion log.

Review of attachment 8717708 [details] [diff] [review]:
-----------------------------------------------------------------

Also! Don't forget to remove the documentation for this API!
Amended to delete the documentation as well. Carrying over r+.
Attachment #8717708 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
OS: Unspecified → All
Hardware: Unspecified → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.