Closed Bug 1247169 Opened 8 years ago Closed 7 years ago

hgtool.py should not try to be smart with mercurial

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: glandium, Assigned: nthomas)

References

Details

Attachments

(3 files, 1 obsolete file)

[buildbotcustom] Remove bundle and mirror support
11.47 KB, patch
rail
: review+
nthomas
: checked-in+
Details | Diff | Splinter Review
[buildbot-configs] Remove base_bundle_urls definitions, v2
3.41 KB, patch
rail
: review+
nthomas
: checked-in+
Details | Diff | Splinter Review
[tools] Remove mirror and bundle support
39.20 KB, patch
rail
: review+
nthomas
: checked-in+
Details | Diff | Splinter Review 
hg-tool is downloading bundles. It should stop doing that because mercurial will do it on its own (requires version 3.6, iirc).
No longer depends on: 1247168
Depends on: 1229532
Depends on: 1254438
Based on dumping the state of a buildbot master for builds, the jobs still using bundles are:

Android 4.2 x86 mozilla-beta build
Android 4.2 x86 mozilla-release build
Android armv7 API 15+ mozilla-beta build
Android armv7 API 15+ mozilla-beta debug build
Android armv7 API 15+ mozilla-release build
Android armv7 API 15+ mozilla-release debug build

TB Linux comm-aurora build
TB Linux comm-aurora leak test build
TB Linux comm-aurora nightly
TB Linux comm-beta build
TB Linux comm-beta leak test build
TB Linux comm-central build
TB Linux comm-central leak test build
TB Linux comm-central nightly
TB Linux comm-esr45 build
TB Linux comm-esr45 leak test build
TB Linux comm-esr45 nightly
TB Linux cypress build
TB Linux cypress leak test build
TB Linux x86-64 comm-aurora build
TB Linux x86-64 comm-aurora leak test build
TB Linux x86-64 comm-aurora nightly
TB Linux x86-64 comm-beta build
TB Linux x86-64 comm-beta leak test build
TB Linux x86-64 comm-central build
TB Linux x86-64 comm-central leak test build
TB Linux x86-64 comm-central nightly
TB Linux x86-64 comm-esr45 build
TB Linux x86-64 comm-esr45 leak test build
TB Linux x86-64 comm-esr45 nightly
TB Linux x86-64 cypress build
TB Linux x86-64 cypress leak test build
TB OS X 10.7 64-bit comm-aurora leak test build
TB OS X 10.7 64-bit comm-beta leak test build
TB OS X 10.7 64-bit comm-central leak test build
TB OS X 10.7 64-bit comm-esr45 leak test build
TB OS X 10.7 64-bit cypress leak test build
TB OS X 10.7 comm-aurora build
TB OS X 10.7 comm-aurora nightly
TB OS X 10.7 comm-beta build
TB OS X 10.7 comm-central build
TB OS X 10.7 comm-central nightly
TB OS X 10.7 comm-esr45 build
TB OS X 10.7 comm-esr45 nightly
TB OS X 10.7 cypress build
TB WINNT 5.2 comm-aurora build
TB WINNT 5.2 comm-aurora leak test build
TB WINNT 5.2 comm-aurora nightly
TB WINNT 5.2 comm-beta build
TB WINNT 5.2 comm-beta leak test build
TB WINNT 5.2 comm-central build
TB WINNT 5.2 comm-central leak test build
TB WINNT 5.2 comm-central nightly
TB WINNT 5.2 comm-esr45 build
TB WINNT 5.2 comm-esr45 leak test build
TB WINNT 5.2 comm-esr45 nightly
TB WINNT 5.2 cypress build
TB WINNT 5.2 cypress leak test build
TB WINNT 6.1 x86-64 comm-central build
TB WINNT 6.1 x86-64 comm-central nightly

Linux ash leak test spidermonkey_tier_1-arm-sim build
Linux autoland leak test spidermonkey_tier_1-arm-sim build
Linux date leak test spidermonkey_tier_1-arm-sim build
Linux fx-team leak test spidermonkey_tier_1-arm-sim build
Linux larch leak test spidermonkey_tier_1-arm-sim build
Linux mozilla-aurora leak test spidermonkey_tier_1-arm-sim build
Linux mozilla-beta leak test spidermonkey_tier_1-arm-sim build
Linux mozilla-central leak test spidermonkey_tier_1-arm-sim build
Linux mozilla-esr45 leak test spidermonkey_tier_1-arm-sim build
Linux mozilla-inbound leak test spidermonkey_tier_1-arm-sim build
Linux mozilla-release leak test spidermonkey_tier_1-arm-sim build
Linux oak leak test spidermonkey_tier_1-arm-sim build
WINNT 5.2 ash leak test spidermonkey_tier_1-compacting build
WINNT 5.2 ash leak test spidermonkey_tier_1-plaindebug build
WINNT 5.2 ash spidermonkey_tier_1-plain build
WINNT 5.2 autoland leak test spidermonkey_tier_1-compacting build
WINNT 5.2 autoland leak test spidermonkey_tier_1-plaindebug build
WINNT 5.2 autoland spidermonkey_tier_1-plain build
WINNT 5.2 date leak test spidermonkey_tier_1-compacting build
WINNT 5.2 date leak test spidermonkey_tier_1-plaindebug build
WINNT 5.2 date spidermonkey_tier_1-plain build
WINNT 5.2 fx-team leak test spidermonkey_tier_1-compacting build
WINNT 5.2 fx-team leak test spidermonkey_tier_1-plaindebug build
WINNT 5.2 fx-team spidermonkey_tier_1-plain build
WINNT 5.2 larch leak test spidermonkey_tier_1-compacting build
WINNT 5.2 larch leak test spidermonkey_tier_1-plaindebug build
WINNT 5.2 larch spidermonkey_tier_1-plain build
WINNT 5.2 mozilla-aurora leak test spidermonkey_tier_1-compacting build
WINNT 5.2 mozilla-aurora leak test spidermonkey_tier_1-plaindebug build
WINNT 5.2 mozilla-aurora spidermonkey_tier_1-plain build
WINNT 5.2 mozilla-beta leak test spidermonkey_tier_1-compacting build
WINNT 5.2 mozilla-beta leak test spidermonkey_tier_1-plaindebug build
WINNT 5.2 mozilla-beta spidermonkey_tier_1-plain build
WINNT 5.2 mozilla-central leak test spidermonkey_tier_1-compacting build
WINNT 5.2 mozilla-central leak test spidermonkey_tier_1-plaindebug build
WINNT 5.2 mozilla-central spidermonkey_tier_1-plain build
WINNT 5.2 mozilla-esr45 leak test spidermonkey_tier_1-compacting build
WINNT 5.2 mozilla-esr45 leak test spidermonkey_tier_1-plaindebug build
WINNT 5.2 mozilla-esr45 spidermonkey_tier_1-plain build
WINNT 5.2 mozilla-inbound leak test spidermonkey_tier_1-compacting build
WINNT 5.2 mozilla-inbound leak test spidermonkey_tier_1-plaindebug build
WINNT 5.2 mozilla-inbound spidermonkey_tier_1-plain build
WINNT 5.2 mozilla-release leak test spidermonkey_tier_1-compacting build
WINNT 5.2 mozilla-release leak test spidermonkey_tier_1-plaindebug build
WINNT 5.2 mozilla-release spidermonkey_tier_1-plain build
WINNT 5.2 oak leak test spidermonkey_tier_1-compacting build
WINNT 5.2 oak leak test spidermonkey_tier_1-plaindebug build
WINNT 5.2 oak spidermonkey_tier_1-plain build

These all all hgtool.py with a --bundle argument. I've got some patches that need testing, hopefully early next quarter.
These would have to land together, due to the lack of config.get in the line if 'config['base_bundle_urls']' in mirrorAndBundleArgs().
Summary: hg-tool should not try to be smart with mercurial → hgtool.py should not try to be smart with mercurial
Bug 1313070 is setting the base_bundle_url pref to [] for Thunderbird. The resulting bundle urls were always a 404 there.
Depends on: 1313070
I looked again at the builds in comment #1:
* there are slightly fewer android builds running in buildbot now, they try to use a bundle and fail, the use a server side bundle
* TB disabled bundles already
* the spidermonkey builds all accept --mirror and --bundle arguments but they're no-op

Therefore we can yank all the hg mirror and bundle support out.
Assignee: nobody → nthomas

        Attachment #8794634 -
        Attachment is obsolete: true

        Attachment #8826408 -
        Flags: review?(rail)

    
    

    
  
Comment on attachment 8794635 [details] [diff] [review]
[buildbotcustom] Remove bundle and mirror support

Rips out support in buildbot.

        Attachment #8794635 -
        Flags: review?(rail)

    
    

    
  


  
* removes support in hgtool.py, and associated tests
* blocklist & hsts/hkpk scripts call hgtool but don't use bundle because they don't get passed
* spidermonkey accepts args for compatibility but doesn't use them
* remove valgrind.sh, which was deprecated in bug 1278611

Also noticed that we're using hg 3.7.3 for the tests instead of 3.9.1. Changing that introduces a test failure so I'll file it separately.

        Attachment #8826412 -
        Flags: review?(rail)

    
    

    
  
Comment on attachment 8794635 [details] [diff] [review]
[buildbotcustom] Remove bundle and mirror support

Review of attachment 8794635 [details] [diff] [review]:
-----------------------------------------------------------------

(lines--)++

        Attachment #8794635 -
        Flags: review?(rail) → review+

    
    

    
  
Comment on attachment 8826408 [details] [diff] [review]
[buildbot-configs] Remove base_bundle_urls definitions, v2

Review of attachment 8826408 [details] [diff] [review]:
-----------------------------------------------------------------

DIAF

        Attachment #8826408 -
        Flags: review?(rail) → review+

    
    

    
  
Comment on attachment 8826412 [details] [diff] [review]
[tools] Remove mirror and bundle support

Review of attachment 8826412 [details] [diff] [review]:
-----------------------------------------------------------------

wheeeeee!!!

        Attachment #8826412 -
        Flags: review?(rail) → review+

    
    

    
  
All in production. Verified Android is OK on beta & release, and spidermonkey on beta (modulo bug 1329935). Emptied out pub/firefox/bundles/ on the ftp server.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 1331388

    
    

    
  
Thank you for cleaning this up!
Component: General Automation → General

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: