Closed
Bug 1247171
Opened 8 years ago
Closed 8 years ago
ValueError: need more than 1 value to unpack in get_git_config
Categories
(MozReview Graveyard :: General, defect)
MozReview Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
I happen to have a git config item with a \n in it, which throws off get_git_config. (I have this in my config ever since I tried to reproduce the same issue in git-cinnabar)
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/34307/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/34307/
|
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8717781 [details] MozReview Request: Bug 1247171 - Handle git config items with a line feed Pushing told me "review requests lack reviewers; visit review url to assign reviewers" but I didn't figure how to do that, so here I am, doing it manually on bugzilla.
Attachment #8717781 -
Flags: review?(gps)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8717781 [details] MozReview Request: Bug 1247171 - Handle git config items with a line feed https://reviewboard.mozilla.org/r/34307/#review31067 Cool. I didn't know about the -z/--null flag.
Attachment #8717781 -
Flags: review?(gps) → review+
|
|
||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/hgcustom/version-control-tools/rev/ed7f91d34841
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Developer Services → MozReview
You need to log in
before you can comment on or make changes to this bug.
Description
•