1247174 - Failure in testing/vcttesting/docker.py during create-test-environment doesn't necessarily match the error message

Status: NEW

(Developer Services :: General, task)

Description

[Mike Hommey [:glandium]]

The error message says:

You will not be able to run tests that require Docker.
Please see https://docs.docker.com/installation/ for how to install Docker.
When Docker is installed, re-run this script
finished creating test environment


Except the actual failure was:

CalledProcessError: Command '[u'<snip>/venv/bin/hg', u'-R', u'<snip>', u'log', u'-r', u'.', u'-T', u'{node|short}']' returned non-zero exit status 255

(which failed because my clone of version-control-tools is not a mercurial repository)

(it would have been nicer if it had failed before creating docker images)

Comment 1

[Mike Hommey [:glandium]]

Here is another failure that says the same thing, but is not related to docker not being installed:

CalledProcessError: Command '['/usr/bin/rsync', '-a', '--delete-before', '--files-from', '/tmp/tmpsK19eK', '/home/glandium/mozilla/version-control-tools', u'rsync://localhost:32776/vct-mount/']' returned non-zero exit status 12

  File "/home/glandium/mozilla/version-control-tools/testing/vcttesting/docker_mach_commands.py", line 90, in build_all
    self.d.build_all_images(verbose=True)
  File "/home/glandium/mozilla/version-control-tools/testing/vcttesting/docker.py", line 1224, in build_all_images
    ansibles=ansible_images, verbose=verbose, use_last=use_last)
  File "/home/glandium/mozilla/version-control-tools/testing/vcttesting/docker.py", line 526, in ensure_images_built
    with self.vct_container(verbose=verbose) as vct_state, futures.ThreadPoolExecutor(len(missing)) as e:
  File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "/home/glandium/mozilla/version-control-tools/testing/vcttesting/docker.py", line 1459, in vct_container
    rsync('-a', '--delete-before', '--files-from', fh.name, ROOT, url)
  File "/home/glandium/mozilla/version-control-tools/testing/vcttesting/docker.py", line 64, in rsync
    subprocess.check_call([prog] + list(args), cwd='/')
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
You will not be able to run tests that require Docker.
Please see https://docs.docker.com/installation/ for how to install Docker.
When Docker is installed, re-run this script
finished creating test environment

Comment 2

[Mike Hommey [:glandium]]

Apparently, the second failure is an indirect consequence of the first one, after I changed the code to handle the git repository: the first failure left the docker setup in a broken state that had to be reset manually.

Comment 3

[Mike Hommey [:glandium]]

Actually that was something else. I'll file a separate bug.